2076 unregsiter true #160
Merged
2076 unregsiter true #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark90
reviewed
Jul 30, 2025
| // Note. If we don't use cloneDeep here we are adding a reference to the rhfValues | ||
| // that changes on every change in the form and triggering effects before we want to. | ||
| addFormInputData(_.cloneDeep(rhfValues), !!errorDetails); | ||
| window.scrollTo(0, 0); |
There was a problem hiding this comment.
Is it important for the submit action to scroll the window?
| // TODO implement save with errors toggle | ||
| if (data) { | ||
| rhf.clearErrors(); | ||
| submitFormFn(); |
There was a problem hiding this comment.
This is basically a retry, right? Which kind of client side errors can lead to this function?
| formInputData, | ||
| hasNext, | ||
| initialData, | ||
| }; |
There was a problem hiding this comment.
that's.. a lot :)
Any way to structure this a bit more, maybe group similar state things together? (feel free to ignore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some loosely related changes in this PR: