Skip to content

2076 unregsiter true #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025
Merged

2076 unregsiter true #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32ca278
2076: Rearrange useEffects. Remove rhf from zodRule definitions
Jul 30, 2025
ed71c0f
Fix translations. Rely on standard translations provided by zod
Jul 30, 2025
7bcb18e
2076: Adds changeset
Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/.changeset/busy-terms-pull.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'pydantic-forms': minor
---

Removes some unused functionality. Introduces shouldRegister=true to react-hook-form creation.
17 changes: 3 additions & 14 deletions frontend/packages/pydantic-forms/src/components/zodValidationsPresets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,16 @@ export const zodValidationPresets: PydanticFormZodValidationPresets = {

let validationRule = z.string().trim();
if (minLength) {
validationRule = validationRule?.min(
minLength,
minLength === 1
? 'Moet ingevuld zijn'
: `Dit veld heeft een minimum lengte van ${minLength} karakters`,
);
validationRule = validationRule?.min(minLength);
}

if (maxLength) {
validationRule = validationRule?.max(
maxLength,
`Dit veld heeft een maximum lengte van ${maxLength} karakters`,
);
validationRule = validationRule?.max(maxLength);
}

if (pattern) {
try {
validationRule = validationRule?.regex(
new RegExp(pattern),
`De invoer is niet volgens het juiste formaat: ${pattern}`,
);
validationRule = validationRule?.regex(new RegExp(pattern));
} catch (error) {
console.error(
'Could not parse validation rule regex',
Expand Down
Loading