New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Y-m-d in default export file #36

Merged
merged 3 commits into from Aug 24, 2017

Conversation

2 participants
@danielbachhuber
Member

danielbachhuber commented Aug 24, 2017

When you have a variety of these in your web root, it's helpful to know
when they were created

Include Y-m-d in default export file
When you have a variety of these in your web root, it's helpful to know
when they were created

@danielbachhuber danielbachhuber added this to the 1.2.1 milestone Aug 24, 2017

@danielbachhuber danielbachhuber requested a review from wp-cli/committers Aug 24, 2017

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Aug 24, 2017

Contributor

Isn't there a BC issue here, in that scripts expect a plain dbname.sql? Also howabout "HH:MM:SS" instead of a random hash to differentiate?

Contributor

gitlost commented Aug 24, 2017

Isn't there a BC issue here, in that scripts expect a plain dbname.sql? Also howabout "HH:MM:SS" instead of a random hash to differentiate?

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Aug 24, 2017

Member

Isn't there a BC issue here, in that scripts expect a plain dbname.sql?

No, a random hash is always/already appended when no filename is explicitly provided.

Also howabout "HH:MM:SS" instead of a random hash to differentiate?

We need the random hash to prevent the filename from being guessed.

Member

danielbachhuber commented Aug 24, 2017

Isn't there a BC issue here, in that scripts expect a plain dbname.sql?

No, a random hash is always/already appended when no filename is explicitly provided.

Also howabout "HH:MM:SS" instead of a random hash to differentiate?

We need the random hash to prevent the filename from being guessed.

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Aug 24, 2017

Contributor

No, a random hash is always/already appended when no filename is explicitly provided.

Ah, always read the code not the comments!

Contributor

gitlost commented Aug 24, 2017

No, a random hash is always/already appended when no filename is explicitly provided.

Ah, always read the code not the comments!

@gitlost gitlost merged commit 5159191 into master Aug 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gitlost gitlost deleted the ymd-export-file branch Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment