fix: Error on Options Pages when no Options Pages exist #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tests to ensure AcfOptionsPages show in the GraphQL Types only if there are ACF Options Pages registered to show in GraphQL - introduce Utils::get_acf_options_pages() - refactor uses of acf_get_options_pages() to use Utils::get_acf_options_pages()
…options-page-location-error
- updated code to pass phpcs & phpstan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where an error would be displayed on the ACF Field Group if no ACF Options Pages were registered.
Does this close any currently open issues?
closes #82
Any relevant logs, error output, GraphiQL screenshots, etc?
Before
An error is displayed in the admin if no ACF Options Pages exist, but the field group is set to a location rule with "acf_option_pages === *"
After
No more error.