Skip to content

fix: Error on Options Pages when no Options Pages exist #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 5, 2023
Merged

fix: Error on Options Pages when no Options Pages exist #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
40af6ed
- only show options pages as a location if there are option pages reg…
jasonbahl Sep 5, 2023
0b3f44a
- add filter for interfaces
jasonbahl Sep 5, 2023
cb440eb
- phpcs, phpstan adjustments
jasonbahl Sep 5, 2023
468f203
Merge branch 'main' into fix/#82-options-page-location-error
jasonbahl Sep 5, 2023
6f8384e
- update workflows to use newer dependencies
jasonbahl Sep 5, 2023
6de8662
Merge commit '468f20304985a225946e85b07b9be21c9dfaae4b' into fix/#82-…
jasonbahl Sep 5, 2023
61329a7
- updated phpcs.xml.dist to match core WPGraphQL
jasonbahl Sep 5, 2023
11e4320
- fix schema upload workflow
jasonbahl Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ jobs:
steps:
- name: Cancel previous runs of this workflow (pull requests only)
if: ${{ github.event_name == 'pull_request' }}
uses: styfle/cancel-workflow-action@0.5.0
uses: styfle/cancel-workflow-action@0.11.0
with:
access_token: ${{ github.token }}

- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upload-schema-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: Generate and Upload WPGraphQL for ACF Schema Artifact
services:
mariadb:
image: mariadb
image: mariadb:10.8.2
ports:
- 3306:3306
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wordpress-coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ jobs:
steps:
- name: Cancel previous runs of this workflow (pull requests only)
if: ${{ github.event_name == 'pull_request' }}
uses: styfle/cancel-workflow-action@0.5.0
uses: styfle/cancel-workflow-action@0.11.0
with:
access_token: ${{ github.token }}

- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
11 changes: 6 additions & 5 deletions access-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
* @return void
*/
function register_graphql_acf_field_type( string $acf_field_type, $config = [] ): void {

add_action( 'wpgraphql/acf/register_field_types', static function ( \WPGraphQL\Acf\FieldTypeRegistry $registry ) use ( $acf_field_type, $config ) {
$registry->register_field_type( $acf_field_type, $config );
} );

add_action(
'wpgraphql/acf/register_field_types',
static function ( \WPGraphQL\Acf\FieldTypeRegistry $registry ) use ( $acf_field_type, $config ) {
$registry->register_field_type( $acf_field_type, $config );
}
);
}
5 changes: 3 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,15 @@
"codeception/util-universalframework": "^1.0",
"phpcompatibility/phpcompatibility-wp": "^2.1",
"phpstan/phpstan": "^1.10",
"szepeviktor/phpstan-wordpress": "1.1.3",
"szepeviktor/phpstan-wordpress": "~1.3.0",
"codeception/module-rest": "^1.4",
"wp-graphql/wp-graphql-testcase": "~2.3",
"wp-graphql/wp-graphql": "^1.14",
"phpunit/phpunit": "^9.5",
"slevomat/coding-standard": "^8.9",
"simpod/php-coveralls-mirror": "^3.0",
"phpstan/extension-installer": "^1.3"
"phpstan/extension-installer": "^1.3",
"wp-cli/wp-cli-bundle": "^2.8"
},
"config": {
"platform": {
Expand Down
Loading