-
-
Notifications
You must be signed in to change notification settings - Fork 121
added pageTitle - to customise HTML head #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added pageFooter - to customise Page Footer updated reportName referring directly instead from suite, so able to display header in feature-overview. updated README
wswebcreation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @muthukumarse
Tnx for the PR. Can you please:
- add tests for this
- fix the review comments
Tnx in advance
| - **Type:** `string` | ||
| - **Mandatory:** No | ||
|
|
||
| You can customise Page Footer if required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you provide an example how it then should like like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page Footer is where it has "Created by wswebcreation. Find me on ICONS"
when i set
pageFooter: 'my own footer'
in report.generate({}) then it overwrite the existing Tag line
| const displayDuration = options.displayDuration || false; | ||
| const durationInMS = options.durationInMS || false; | ||
| const pageTitle = options.pageTitle || 'Multiple Cucumber HTML Reporter'; | ||
| const pageFooter = options.pageFooter || "<div class='created-by'><p>Created by wswebcreation. Find me on:</p><a href='http://www.wswebcreation.nl/' target='_blank'><i class='fa fa-rss-square fa-2x'></i></a><a href='https://github.com/wswebcreation/' target='_blank'><i class='fa fa-github-square fa-2x'></i></a><a href='http://nl.linkedin.com/in/wimselles' target='_blank'><i class='fa fa-linkedin-square fa-2x'></i></a><a href='http://stackoverflow.com/users/5911978/wswebcreation' target='_blank'><i class='fa fa-stack-overflow fa-2x'></i></a></div>"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'de like the html in the file where it belongs, so please check in the template files what needs to be loaded, if / else can be used there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pageTitle - is which shows as HTML file title ( I like to have specific project name instead)
pageFooter - again same as above comment
what i see, currently don't have support to load the custom template. So i though this will be quicker to acheive
|
hi can you review the my comment. I am waiting, since i using this as dependency. thanks |
|
I'm going to merge this PR and make some little changes before I bring a new release. Tnx for your effort. |
|
Sure please. Thanks |
|
New version 1.9.0 has been release. Tnx again for you work |
|
@muthukumarse @wswebcreation Could you please point me a usage example how to create |
added pageFooter - to customise Page Footer
updated reportName referring directly instead from suite, so able to display header in feature-overview.
updated README