Outputs #223
Merged
Outputs #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| super(name); | ||
| } | ||
|
|
||
| public Map<String, Object> toMap() { |
| this.error = props.get("error", String.class); | ||
| this.output = props.get("output", String.class); | ||
| this.error = props.get("error", String.class); | ||
| this.inputs = JsonUtils.read(props.get("inputs", InputStream.class), InputValues.class); |
There was a problem hiding this comment.
fallback executableInputs to maintain backward compatibility
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for execution outputs functionality, allowing scripts to generate downloadable files. The changes include new type definitions for outputs, a download UI component, and backend support for storing and serving output files.
- Introduces
OutputandOutputstypes for defining downloadable script outputs - Adds
ExecutionDownloadOutputsButtoncomponent for downloading execution outputs - Restructures input/output handling by moving
inputsfromExecutabletoExecutioninterface
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui.frontend/src/utils/api.types.ts | Adds Output and Outputs types, moves inputs from Executable to Execution |
| ui.frontend/src/pages/ScriptView.tsx | Updates API call structure to move inputs outside of code object |
| ui.frontend/src/pages/ExecutionView.tsx | Integrates download button and updates UI layout |
| ui.frontend/src/pages/ConsolePage.tsx | Adds execution download functionality with type tracking |
| ui.frontend/src/components/ExecutionDownloadOutputsButton.tsx | New component for downloading execution outputs |
| core/src/main/java/dev/vml/es/acm/core/servlet/ExecutionOutputServlet.java | New servlet for serving execution output files |
| core/src/main/java/dev/vml/es/acm/core/code/Output.java | New class for individual output definitions |
| core/src/main/java/dev/vml/es/acm/core/code/Outputs.java | New class for managing output collections |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...le/src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACME-203_outputs.groovy
Outdated
Show resolved
Hide resolved
...le/src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACME-203_outputs.groovy
Outdated
Show resolved
Hide resolved
core/src/main/java/dev/vml/es/acm/core/code/ExecutionContextOptions.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.