This repository was archived by the owner on May 15, 2024. It is now read-only.
A few fixes for the release. #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mattleibow
commented
May 5, 2018
| tabsBuilder.SetShowTitle(true); | ||
| var tabsIntent = tabsBuilder.Build(); | ||
| tabsIntent.Intent.SetFlags(ActivityFlags.ClearTop); | ||
| tabsIntent.Intent.SetFlags(ActivityFlags.NewTask); |
There was a problem hiding this comment.
Added the flags - also moved the SetShowTitle to before the intent is built.
mattleibow
commented
May 5, 2018
| var encData = Convert.FromBase64String(encStr); | ||
| var ks = new AndroidKeyStore(context, Alias, AlwaysUseAsymmetricKeyStorage); | ||
| decryptedData = ks.Decrypt(encData); | ||
| } |
There was a problem hiding this comment.
Wrapped the retrieved value in a null check - don't decode null.
mattleibow
commented
May 5, 2018
| public TextToSpeechImplementation() | ||
| { | ||
| } | ||
|
|
mattleibow
commented
May 5, 2018
| tts = null; | ||
| } | ||
|
|
||
| base.Dispose(disposing); |
There was a problem hiding this comment.
Whaaa?! Just override the correct method, and not create a new method that will never be called.
mattleibow
commented
May 5, 2018
| } | ||
| tts.SetPitch(settings.Pitch.Value); | ||
| else | ||
| tts.SetPitch(TextToSpeech.PitchDefault); |
There was a problem hiding this comment.
Setting the default value as the tts object is shared across speaks.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mattleibow
commented
May 5, 2018
| } | ||
| return can; | ||
| } | ||
| } |
There was a problem hiding this comment.
First check MFMailComposeViewController and then try mailto:.
This is a bit stupid since there is always a mail app, and at the same time the only app supported by mailto is the default app - even if Outlook is installed and set up, the mailto will keep asking you to set up an account in the Apple app.
Redth
approved these changes
May 5, 2018
jamesmontemagno
added a commit
that referenced
this pull request
Jun 21, 2018
* GH-221: Add iOS SecAccessible properties (#223) * Address #221, use AfterFirstUnlockThisDeviceOnly to match other platforms. Although allow a platform specific override to set accessible state. * Add tests * Added iOS specific prop to set SecAccessible * Default to AfterFirstUnlock on iOS SecureStorage * A few fixes for the release. (#228) * Setting the correct flags for Chrome Tabs. Fixes #225 * Make sure that there is data to decrypt before starting. Fixes #226 * Fixes for TTS. Fixes #227 * A bit of the fixes for emails on iOS. Relates to #224 * Update the email bit for iOS #224 * Cleaning up the code #224 * Make sure to set the email properties. Fixes #229 * Update SDK Extras This fixes a lot of references that were required on android that aren't. * Update Readme with Installation information. (#237) * Update Readme with Installation information. * Update README.md * Update README.md * Adding the initial work to get Tizen started. #23 * Revert "Adding the initial work to get Tizen started. #23" This reverts commit 58b6041. * Update the docs with the latest APIs (#233) Add docs for SecAccessible * GH-245: Add Orientation Sensor (#249) * Add Orientation Sensor * Add Orientation Sensor * Remove .csproj clutter * "orientationsensor" --> "orientation sensor" or just "orientation" * GH-192: Added DateTime to Preferences (#232) * Added DateTime to preferences. Fixes #192 - also properly using overloads * Added some unit tests * Added the docs for the new Preferences APIs * Update Readme with Device Display Information Added link to Current Features for Device Display Information * Fixes #258 and Fixes #255 (#259) * Fixes #258 * put vectors nuget everywhere. * NuGet is broken - https://developercommunity.visualstudio.com/content/problem/232996/warning-nu1603-runtimenativesystemiocompression-41.html * The NuGet doesn't add the assembly references from the GAC * We need to use a later version of the iOS SDK * Fix typo (#274) * Fix up null checks when getting lask known location. * Additional Null checks * GH-240 Add IsMainThread detection API (#277) * Add IsMainThread detection API * Add platform tests for main thread * Update docs and add more platform tests * iOS secure storage simulator tests (#247) (#278) * iOS secure storage simulator tests (#247) * Remove line that skips test on virtual devices * Adding keychain-access-groups in Entitlements.plist * Setting CodeSign entitlements for Debug configuration * Making same entitlement.plist changes for iOS sample * Removing specific code sign key * Removing physical device trait for iOS SecureStorageTests * Update DeviceTests.iOS.csproj * Update Samples.iOS.csproj * Add configs for codesign on release * Fixes #181 Allowing setting of calibration for heading. (#282) * GH-254 Update Support Packages, Forms, and Reference Vectors (#279) * Update Support Packages, Forms, and Reference Vectors * Bump targetsdk * Fix android build :) * Fix build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A few fixes for the release.
Bugs Fixed
API Changes
None.
Behavioral Changes
Bug fixes.
PR Checklist