Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

GH-245: Add Orientation Sensor #249

Merged
merged 4 commits into from
May 14, 2018
Merged

GH-245: Add Orientation Sensor #249

merged 4 commits into from
May 14, 2018

Conversation

charlespetzold
Copy link
Contributor

@charlespetzold charlespetzold commented May 12, 2018 •
edited
Loading

Description of Change

Add Orientation Sensor to API (rationale and description in issue #245)

API Changes

public static class OrientationSensor
{
    public static event OrientationSensorChangedEventHandler ReadingChanged;
    public static bool IsMonitoring { get; private set; }
    public static void Start(SensorSpeed sensorSpeed);
    public static void Stop();
}

public delegate void OrientationSensorChangedEventHandler(OrientationSensorChangedEventArgs e);

public class OrientationSensorChangedEventArgs : EventArgs
{
    public OrientationSensorData Reading { get; }
}

public struct OrientationSensorData
{
    public System.Numerics.Quaternion Orientation { get; }
}

@dend

This comment has been minimized.

Sign in to view
jamesmontemagno
jamesmontemagno suggested changes May 12, 2018
View reviewed changes
Copy link
Collaborator

@jamesmontemagno jamesmontemagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny changes, but amazing!

Samples/Samples/Samples.csproj Outdated
<ProjectReference Include="..\..\Xamarin.Essentials\Xamarin.Essentials.csproj" />
</ItemGroup>

<ItemGroup>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff gets auto added, but can be removed.

Xamarin.Essentials/Xamarin.Essentials.csproj Outdated
<Compile Include="**\*.ios.cs" />
<Compile Include="**\*.ios.*.cs" />
</ItemGroup>
<ItemGroup>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also be removed.

@dend

This comment has been minimized.

Sign in to view
@jamesmontemagno
Copy link
Collaborator

Build

@mattleibow mattleibow changed the title Add Orientation Sensor GH-245: Add Orientation Sensor May 13, 2018
@mattleibow
Copy link
Contributor

Nice!

mattleibow
mattleibow suggested changes May 13, 2018
View reviewed changes
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, just want to change the user visible text from "orientationsensor" to "orientation sensor" (with a space)

Samples/Samples/ViewModel/HomeViewModel.cs Outdated
"Have a look at the accelerometer, compass, gyroscope and magnetometer.",
new[] { "accelerometer", "compass", "gyroscope", "magnetometer", "sensors", "hardware", "device" }),
"Have a look at the accelerometer, compass, gyroscope, magnetometer, and orientationsensor.",
new[] { "accelerometer", "compass", "gyroscope", "magnetometer", "orientationsensor", "sensors", "hardware", "device" }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just "orientation"

Samples/Samples/ViewModel/HomeViewModel.cs Outdated
new[] { "compass", "magnetometer", "sensors", "hardware", "device" }),
new SampleItem(
"📏",
"OrientationSensor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Orientation Sensor"

Samples/Samples/ViewModel/HomeViewModel.cs Outdated
"OrientationSensor",
typeof(OrientationSensorPage),
"Retrieve orientation of the device in 3D space.",
new[] { "orientationsensor", "sensors", "hardware", "device" }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"orientation"

@dend

This comment has been minimized.

Sign in to view
@mattleibow
Copy link
Contributor

build

@jamesmontemagno jamesmontemagno merged commit 3432c0e into xamarin:master May 14, 2018
jamesmontemagno added a commit that referenced this pull request Jun 21, 2018
@jamesmontemagno
Merge master into main (#308)
a09a031 
* GH-221: Add iOS SecAccessible properties (#223)

* Address #221, use AfterFirstUnlockThisDeviceOnly to match other platforms. Although allow a platform specific override to set accessible state.

* Add tests

* Added iOS specific prop to set SecAccessible

* Default to AfterFirstUnlock on iOS SecureStorage

* A few fixes for the release. (#228)

* Setting the correct flags for Chrome Tabs. Fixes #225

* Make sure that there is data to decrypt before starting. Fixes #226

* Fixes for TTS. Fixes #227

* A bit of the fixes for emails on iOS. Relates to #224

* Update the email bit for iOS #224

* Cleaning up the code #224

* Make sure to set the email properties. Fixes #229

* Update SDK Extras

This fixes a lot of references that were required on android that aren't.

* Update Readme with Installation information. (#237)

* Update Readme with Installation information.

* Update README.md

* Update README.md

* Adding the initial work to get Tizen started. #23

* Revert "Adding the initial work to get Tizen started. #23"

This reverts commit 58b6041.

* Update the docs with the latest APIs (#233)

Add docs for SecAccessible

* GH-245: Add Orientation Sensor (#249)

* Add Orientation Sensor

* Add Orientation Sensor

* Remove .csproj clutter

* "orientationsensor" --> "orientation sensor" or just "orientation"

* GH-192: Added DateTime to Preferences (#232)

* Added DateTime to preferences. Fixes #192
 - also properly using overloads

* Added some unit tests

* Added the docs for the new Preferences APIs

* Update Readme with Device Display Information

Added link to Current Features for Device Display Information

* Fixes #258 and Fixes #255 (#259)

* Fixes #258
* put vectors nuget everywhere.
* NuGet is broken - https://developercommunity.visualstudio.com/content/problem/232996/warning-nu1603-runtimenativesystemiocompression-41.html
* The NuGet doesn't add the assembly references from the GAC
* We need to use a later version of the iOS SDK

* Fix typo (#274)

* Fix up null checks when getting lask known location.

* Additional Null checks

* GH-240 Add IsMainThread detection API (#277)

* Add IsMainThread detection API

* Add platform tests for main thread

* Update docs and add more platform tests

* iOS secure storage simulator tests (#247) (#278)

* iOS secure storage simulator tests (#247)

* Remove line that skips test on virtual devices

* Adding keychain-access-groups in Entitlements.plist

* Setting CodeSign entitlements for Debug configuration

* Making same entitlement.plist changes for iOS sample

* Removing specific code sign key

* Removing physical device trait for iOS SecureStorageTests

* Update DeviceTests.iOS.csproj

* Update Samples.iOS.csproj

* Add configs for codesign on release

* Fixes #181 Allowing setting of calibration for heading. (#282)

* GH-254 Update Support Packages, Forms, and Reference Vectors (#279)

* Update Support Packages, Forms, and Reference Vectors

* Bump targetsdk

* Fix android build :)

* Fix build
@janusw janusw mentioned this pull request Oct 9, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mattleibow mattleibow mattleibow approved these changes

@jamesmontemagno jamesmontemagno jamesmontemagno left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charlespetzold @dend @jamesmontemagno @mattleibow