This repository has been archived by the owner on May 1, 2024. It is now read-only.
Set the Id field for Android Views created by Forms #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
approved these changes
Jun 21, 2017
Xamarin.Forms.Controls/TestCases.cs
Outdated
| select MakeIssueCell (issueModel.Name, issueModel.Description, issueModel.Action); | ||
|
|
||
| // TODO hartez 2017/06/21 09:12:51 Restore the original order |
There was a problem hiding this comment.
Blergh. I did restore the order, then I forgot to remove the comment.
jassmith
approved these changes
Jun 21, 2017
rmarinho
pushed a commit
that referenced
this pull request
Jun 22, 2017
assemhakmeh
added a commit
to assemhakmeh/Xamarin.Forms
that referenced
this pull request
Jul 28, 2017
* 2.3.5: [UWP] Fixes for usage of XF with .net native toolchain (xamarin#1024) [UWP] Make sure to update HitTestVisible when IsEnable changes (xamarin#1015) [Android] Dispose check before setting properties on Button (xamarin#1013) Add missing member variable to FormsApplicationActivity Fix NRE when background color of button set in FormsApplicationActivity (xamarin#1010) Fix border on android buttons (xamarin#941) [iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (xamarin#994) Set the Id field for Android Views created by Forms xamarin#1004 Fix build Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (xamarin#961) [Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (xamarin#915) Remove debug outputs (xamarin#1008) Add check for instance of UITableView (xamarin#885) [XamlC] fix release builds of Xaml Unit Tests Dispose check on ButtonRenderer (xamarin#975) [previewer] make sure we do not crash even if the previewer doesn't s… (xamarin#946) [XamlC] fix build Remove VisualElement finalizer (xamarin#918) [XamlC] process symbols if DebugType is set (xamarin#925)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Because Forms doesn't set the
Idvalue for Android Views it creates, some methods (most notablyBackStackRecord.configureTransitions) which search for Views byIdand cast them were failing because all of the Views had the default ofNO_ID(-1).This change sets the
Idfield for the various renderers and for theModalContainerto prevent this issue.Bugs Fixed
API Changes
None
Behavioral Changes
None
PR Checklist