Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[XamlC] process symbols if DebugType is set #925

Merged
merged 1 commit into from
May 16, 2017
Merged

[XamlC] process symbols if DebugType is set #925

merged 1 commit into from
May 16, 2017

Conversation

@StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented May 16, 2017 •
edited by samhouts
Loading

Description of Change

It can happen that DebugType is set and DebugSymbols is not. In that case, a .pdb is generated, and we should process it to avoid a linker failure.

This needs to be back ported to 2.3.5, and eventually even to 2.3.4

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix requested a review from samhouts May 16, 2017 14:04
@StephaneDelcroix StephaneDelcroix requested a review from jassmith May 16, 2017 14:04
@jassmith jassmith merged commit f01cf88 into master May 16, 2017
jassmith pushed a commit that referenced this pull request May 16, 2017
@StephaneDelcroix
[XamlC] process symbols if DebugType is set (#925)
bb632ea
jassmith pushed a commit that referenced this pull request May 16, 2017
@StephaneDelcroix
[XamlC] process symbols if DebugType is set (#925)
94e3702
@rmarinho rmarinho deleted the fix-bz53805 branch June 22, 2017 10:47
@boguslawblonski
Copy link

boguslawblonski commented Jun 28, 2017 •
edited
Loading

yes how in title it occures also on version 2.4.x => 2.4.3.247 (in mine case), happend to after xamarin update 2.4.3.231 to 2.4.3.247 on our jenkins

@StephaneDelcroix
Copy link
Member Author

StephaneDelcroix commented Jun 28, 2017 •
edited
Loading

@boguslawblonski I don't understand your comment. if you have an issue with this, please open a bugzilla ticket with a reproduction attached as we do not monitor discussion on closed PRs.

@boguslawblonski
Copy link

boguslawblonski commented Jun 28, 2017 •
edited
Loading

I just wanted to confirm your "and eventually even to 2.3.4", yes it is true it also happens on 2.4.3.247

@StephaneDelcroix
Copy link
Member Author

this fixes is present in 2.4.3.247

@boguslawblonski
Copy link

boguslawblonski commented Jun 28, 2017 •
edited
Loading

We updated xamarin.form 2.4.3.231 to 2.4.3.247 and our jenkins (on mackin cloud) bug occured.
Works fine, on dev local enviroment, but not on CI on macincloud.

Fix for us was temporarily editing the Xamarin.Forms.targets file, which for us lived in:
packages\Xamarin.Forms.2.3.4.247\build\portable-win+net45+wp80+win81+wpa81+MonoAndroid10+Xamarin.iOS10+xamarinmac20
and removed the DebugType = "$(DebugType)" line.

Sorry not mine enviroment, can't give you propper steps to reproduce.
but maybe this will help you:
https://support.macincloud.com/support/solutions/articles/8000032728-xamarin-updated-to-6-3-0-864

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request Jul 28, 2017
@assemhakmeh
Merge branch '2.3.5' into ios-fastrenderers
942dd53 
* 2.3.5:
  [UWP] Fixes for usage of XF with .net native toolchain (xamarin#1024)
  [UWP] Make sure to update HitTestVisible when IsEnable changes (xamarin#1015)
  [Android] Dispose check before setting properties on Button (xamarin#1013)
  Add missing member variable to FormsApplicationActivity
  Fix NRE when background color of button set in FormsApplicationActivity (xamarin#1010)
  Fix border on android buttons  (xamarin#941)
  [iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (xamarin#994)
  Set the Id field for Android Views created by Forms xamarin#1004
  Fix build
  Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (xamarin#961)
  [Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (xamarin#915)
  Remove debug outputs (xamarin#1008)
  Add check for instance of UITableView (xamarin#885)
  [XamlC] fix release builds of Xaml Unit Tests
  Dispose check on ButtonRenderer (xamarin#975)
  [previewer] make sure we do not crash even if the previewer doesn't s… (xamarin#946)
  [XamlC] fix build
  Remove VisualElement finalizer (xamarin#918)
  [XamlC] process symbols if DebugType is set (xamarin#925)
@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018
@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018
mattleibow pushed a commit that referenced this pull request Jan 28, 2021
@jamesmontemagno @Redth
Fixes #917, make sure to dispose after javacast (#925)
6007244 
* Fixes #917, make sure to dispose after javacast

* C# 8 madness!

* ShareFile: describe contentType ctor arg

This is related to https://github.com/MicrosoftDocs/xamarin-docs/issues/2246

* Clarify ContentType API (#958)

* Clarify ContentType API

* Clarify content type API

* Clarify Content Type api
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samhouts samhouts Awaiting requested review from samhouts

@jassmith jassmith Awaiting requested review from jassmith

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@StephaneDelcroix @boguslawblonski @jassmith @samhouts @dnfclas