This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] Dispose check before setting properties on Button #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void UpdateBitmap() | ||
| { | ||
| if (Element == null) | ||
| if (Element == null || _isDisposed) |
There was a problem hiding this comment.
can't we do the check at a single place, in OnPropertyChanged ? and do it on the base class, so it applies to all controls ?
There was a problem hiding this comment.
These methods are called all over this renderer, not just in OnPropertyChanged. The original PR that "fixed" this issue added it in just OnElementChanged. This seemed like the best way to prevent regressing this bug, and since it's a crasher, I wanted to be safe.
rmarinho
approved these changes
Jun 26, 2017
| void UpdateDrawable() | ||
| { | ||
| _backgroundTracker.UpdateDrawable(); | ||
| _backgroundTracker?.UpdateDrawable(); |
There was a problem hiding this comment.
Just wondering why there is no disposed check here?
|
Were latest checks included into 2.3.5.255-pre5? Still crashing with "CANNOT ACCESS A DISPOSED OBJECT. OBJECT NAME: 'XAMARIN.FORMS.PLATFORM.ANDROID.FASTRENDERERS.BUTTONRENDERER'" from within IVisualElementRenderer.GetDesiredSize. Full call stack:
|
assemhakmeh
added a commit
to assemhakmeh/Xamarin.Forms
that referenced
this pull request
Jul 28, 2017
* 2.3.5: [UWP] Fixes for usage of XF with .net native toolchain (xamarin#1024) [UWP] Make sure to update HitTestVisible when IsEnable changes (xamarin#1015) [Android] Dispose check before setting properties on Button (xamarin#1013) Add missing member variable to FormsApplicationActivity Fix NRE when background color of button set in FormsApplicationActivity (xamarin#1010) Fix border on android buttons (xamarin#941) [iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (xamarin#994) Set the Id field for Android Views created by Forms xamarin#1004 Fix build Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (xamarin#961) [Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (xamarin#915) Remove debug outputs (xamarin#1008) Add check for instance of UITableView (xamarin#885) [XamlC] fix release builds of Xaml Unit Tests Dispose check on ButtonRenderer (xamarin#975) [previewer] make sure we do not crash even if the previewer doesn't s… (xamarin#946) [XamlC] fix build Remove VisualElement finalizer (xamarin#918) [XamlC] process symbols if DebugType is set (xamarin#925)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Clicking a button quickly to Navigate pages can cause a crash because we weren't always checking to see if the control was disposed. Now we're checking all over the place.
Bugs Fixed
API Changes
None
Behavioral Changes
None
PR Checklist