This repository was archived by the owner on May 1, 2024. It is now read-only.
Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jassmith
suggested changes
Jun 2, 2017
| TextView actionBarTitleTextView = null; | ||
|
|
||
| if(Forms.IsLollipopOrNewer) | ||
| int actionBarTitleId = _context.Resources.GetIdentifier("action_bar_title", "id", "android"); |
There was a problem hiding this comment.
the only thing I don't like about this change is it changes the preference order of action_bar_title/toolbar usage to be inverse what it was before. It would be good to retain the preference ordering just in case there are any oddball scenarios out there.
jimmgarrido
force-pushed
the
actionbar_crash
branch
from
a114f33 to
12ebbea
Compare
|
@jassmith Re-did the fix so it maintains the original preference order 👍 |
Therzok
reviewed
Jun 3, 2017
| } | ||
| else | ||
|
|
||
| if(actionBarTitleTextView == null) |
| { | ||
| actionBarTitleTextView = (TextView)toolbar.GetChildAt(i); | ||
| break; | ||
| if (toolbar.GetChildAt(i) is TextView) |
There was a problem hiding this comment.
GetChildAt(i) is being called twice. Maybe use c#7:
GetChildAt(i) is TextView textView and use that in the inner block.
There was a problem hiding this comment.
yeah let's fix this and do only 1 getChild
rmarinho
suggested changes
Jun 21, 2017
| { | ||
| actionBarTitleTextView = (TextView)toolbar.GetChildAt(i); | ||
| break; | ||
| if (toolbar.GetChildAt(i) is TextView) |
There was a problem hiding this comment.
yeah let's fix this and do only 1 getChild
jimmgarrido
force-pushed
the
actionbar_crash
branch
from
f5d3af7 to
aba158e
Compare
rmarinho
suggested changes
Jun 21, 2017
| Toolbar toolbar = (Toolbar)((Activity)_context).FindViewById(actionbarId); | ||
|
|
||
| for( int i = 0; i < toolbar.ChildCount; i++ ) | ||
| var toolbar = (ViewGroup)((Activity)_context).FindViewById(actionbarId); |
There was a problem hiding this comment.
as ViewGroup instead of explicit cast here please..
rmarinho
approved these changes
Jun 21, 2017
jassmith
approved these changes
Jun 21, 2017
|
this is failing @jimmgarrido |
rmarinho
suggested changes
Jun 22, 2017
|
@rmarinho done 👍 |
rmarinho
approved these changes
Jun 22, 2017
rmarinho
pushed a commit
that referenced
this pull request
Jun 22, 2017
…msApplicationActivity (#961) * Fix possible crash on API 21+ at launch * Do not use an explicit cast * Do not use C# 7 pattern matching
assemhakmeh
added a commit
to assemhakmeh/Xamarin.Forms
that referenced
this pull request
Jul 28, 2017
* 2.3.5: [UWP] Fixes for usage of XF with .net native toolchain (xamarin#1024) [UWP] Make sure to update HitTestVisible when IsEnable changes (xamarin#1015) [Android] Dispose check before setting properties on Button (xamarin#1013) Add missing member variable to FormsApplicationActivity Fix NRE when background color of button set in FormsApplicationActivity (xamarin#1010) Fix border on android buttons (xamarin#941) [iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (xamarin#994) Set the Id field for Android Views created by Forms xamarin#1004 Fix build Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (xamarin#961) [Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (xamarin#915) Remove debug outputs (xamarin#1008) Add check for instance of UITableView (xamarin#885) [XamlC] fix release builds of Xaml Unit Tests Dispose check on ButtonRenderer (xamarin#975) [previewer] make sure we do not crash even if the previewer doesn't s… (xamarin#946) [XamlC] fix build Remove VisualElement finalizer (xamarin#918) [XamlC] process symbols if DebugType is set (xamarin#925)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The changes made in #631 and #835 were causing an InvalidCastException when using the Holo theme on Lollipop or higher since that theme does not use a Toolbar.
This fixes it by first checking if there is the older ActionBarTextView on all Android versions and if not, then checking for a Toolbar. This also includes a null check for the Toolbar for situations were it is not present, e.g. using a NoActionBar theme.
Bugs Fixed
API Changes
None
Behavioral Changes
None
PR Checklist