Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet][msbuild] Strip symbols from native executable #11378

Merged
merged 4 commits into from
May 2, 2021
Merged

[dotnet][msbuild] Strip symbols from native executable #11378

merged 4 commits into from
May 2, 2021

Conversation

spouliot
Copy link
Contributor

We have to consider (setup and process) libSystem.Globalization.Native
in order not to remove the required symbols when stripping the native
executable.

Size MySingleView.app
4,578,476 legacy
17,502,741 dotnet before
11,169,432 dotnet after

[dotnet][msbuild] Strip symbols from native executable
9e71199 
We have to consider (setup and process) `libSystem.Globalization.Native`
in order not to remove the required symbols when stripping the native
executable.
@spouliot spouliot added the not-notes-worthy Ignore for release notes label Apr 29, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

Test results

2 tests failed, 105 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug: Failed
  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1096.BigSur
Merge 9e71199 into a4426e8

@rolfbjarne
Copy link
Member

This seems to be the error (which shows locally up with #11380 applied):

Tool xcrun execution finished (exit code = 1).

Undefined symbols for architecture x86_64:
  "_GlobalizationNative_LoadICUData", referenced from:
     -u command line option
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@spouliot
Copy link
Contributor Author

Interesting... it's all Catalyst and I figured out (yesterday for Maui) that it has the (non system) ICU code (like iOS and tvOS). That's likely the same fix that's required here...

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

Test results

2 tests failed, 105 tests passed.

Failed tests

  • link all/Mac Catalyst/Debug: Failed (Tests run: 95 Passed: 91 Inconclusive: 0 Failed: 1 Ignored: 3)
  • link sdk/Mac Catalyst/Debug: Failed (Tests run: 135 Passed: 122 Inconclusive: 6 Failed: 1 Ignored: 12)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge f795ad1 into e2d6552

@spouliot
Copy link
Contributor Author

spouliot commented May 2, 2021

Failures are unrelated, known (network) issues -> https://github.com/xamarin/maccore/issues/1083

@spouliot spouliot merged commit 5ef7fb2 into xamarin:main May 2, 2021
@spouliot spouliot deleted the dotnet-strip-executable branch May 2, 2021 19:06
@spouliot spouliot mentioned this pull request Jun 4, 2021
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spouliot @vs-mobiletools-engineering-service2 @rolfbjarne @dalexsoto @mandel-macaque @tj-devel709