Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet][linker] Add a shared ILLink.LinkAttributes.xml file for the platform assemblies #11424

Merged
merged 2 commits into from
May 5, 2021

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented May 3, 2021

No description provided.

@spouliot spouliot requested a review from rolfbjarne as a code owner May 3, 2021 23:00
@spouliot spouliot added the not-notes-worthy Ignore for release notes label May 3, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)

🎉 All 82 tests passed 🎉

Pipeline on Agent XAMBOT-1094.BigSur'
Merge ace2d47 into b720b44

<attribute internal="RemoveAttributeInstances" />
</type>
</assembly>
</linker>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)

🎉 All 82 tests passed 🎉

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 8a2cacd into 41bf71a

@spouliot spouliot merged commit a3cf2ea into xamarin:main May 5, 2021
@spouliot spouliot deleted the dotnet-linkattributes-xml branch May 5, 2021 12:28
@spouliot spouliot mentioned this pull request Jun 4, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants