[linker] Split CoreTypeMapStep into two parts #11474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly extracted `RegistrarRemovalTrackingStep` can be used inside `dotnet-linker` to remove the dynamic registrar (if not required by some other code).
rolfbjarne
approved these changes
May 7, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) Test results1 tests failed, 106 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur |
unrelated failure, known issue tracking in https://github.com/xamarin/maccore/issues/2414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly extracted
RegistrarRemovalTrackingStepcan be used insidedotnet-linkerto remove the dynamic registrar (if not required by someother code).