[dotnet/msbuild] Add support for using LLVM to build .NET apps. Fixes #11379. #12136
Conversation
…App in .NET from the command line.
…er steps. So that the ComputeAOTArguments can compute the llvm-path value to pass to the AOT compiler (the llvm-path value states where the opt and llc command-line tools are, and they're next to the AOT compiler).
… specify output paths. This deduplicates a little bit code to compute the output path.
rolfbjarne
requested review from
emaf,
mandel-macaque and
spouliot
as code owners
rolfbjarne
added
not-notes-worthy
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 119 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
| @@ -703,7 +705,7 @@ | |||
| Condition="'$(_SdkIsSimulator)' != 'true' And '$(_PlatformName)' != 'macOS'" | |||
| DependsOnTargets="_ComputeVariables" | |||
| Inputs="@(_AssembliesToAOT)" | |||
| Outputs="@(_AssembliesToAOT -> '$(_AOTOutputDirectory)%(Arch)\%(Filename)%(Extension).o')"> | |||
| Outputs="@(_AssembliesToAOT -> '%(ObjectFile)');@(_AssembliesToAOT -> '%(LLVMFile)');"> | |||
There was a problem hiding this comment.
@rolfbjarne are both ObjectFile and LLVMFile ITaskItem outputs of any task? I'm assuming those files will be produced by a task executed on macOS, so we need those to be an output prop of a task so they are copied to Windows to make the Inputs/Outputs check work, otherwise this target will always be executed from Windows.
There was a problem hiding this comment.
Yeah, I think that should work!
Before we can make it the default, we have to implement it :) Making it the default once it's working is easy enough. |
… make the build work correctly on windows.
hmm... I thought this PR was the (last) missing piece. |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 121 tests passed 🎉Pipeline on Agent XAMBOT-1100.BigSur' |
I've created #12147 to track making LLVM the default for release builds. |
|
/sudo backport release/6.0.1xx-preview7 |
|
Backport Job to branch release/6.0.1xx-preview7 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5007997 for more details. |
Fixes #11379.