CA-250748: MTU on pif does not always sync to xapi db #3007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
reviewed
Apr 25, 2017
ocaml/xapi/nm.ml
Outdated
| let mtu = Int64.of_int (Net.Interface.get_mtu dbg ~name:bridge) in | ||
| Db.PIF.set_MTU ~__context ~self:pif ~value:mtu | ||
| with _ -> | ||
| debug "could not update MTU field on PIF %s" rc.API.pIF_uuid |
There was a problem hiding this comment.
I think this should have a priority higher than debug - at least info and I would argue warning is appropriate.
There was a problem hiding this comment.
This line wasn't changed, just re-indented. But yes, let's fix it and make it a warn now that we are here.
robhoes
requested changes
Apr 25, 2017
ocaml/xapi/nm.ml
Outdated
| (* sync MTU *) | ||
| try | ||
| let mtu = Int64.of_int (Net.Interface.get_mtu dbg ~name:bridge) in | ||
| Db.PIF.set_MTU ~__context ~self:pif ~value:mtu |
There was a problem hiding this comment.
We can optimise it a little and only do the DB set if the current MTU is different from the one in the DB (rc.API.pIF_MTU). This is more important now that this is executed unconditionally.
Fix when pif-plug is called, the mtu is not sync to xapi db. Signed-off-by: Taoyong Ding <taoyong.ding@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Taoyong Ding taoyong.ding@citrix.com