Skip to content

CA-250748: MTU on pif does not always sync to xapi db #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2017
Merged

CA-250748: MTU on pif does not always sync to xapi db #3007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions ocaml/xapi/nm.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,18 +462,17 @@ let bring_pif_up ~__context ?(management_interface=false) (pif: API.ref_PIF) =
let master = Db.Bond.get_master ~__context ~self:bond in
Db.PIF.set_currently_attached ~__context ~self:master ~value:false
end;

(* sync MTU *)
(try
let mtu = Int64.of_int (Net.Interface.get_mtu dbg ~name:bridge) in
Db.PIF.set_MTU ~__context ~self:pif ~value:mtu
with _ ->
debug "could not update MTU field on PIF %s" rc.API.pIF_uuid
);

Xapi_mgmt_iface.on_dom0_networking_change ~__context
end
)
end;

(* sync MTU *)
try
let mtu = Int64.of_int (Net.Interface.get_mtu dbg ~name:bridge) in
if mtu <> rc.API.pIF_MTU then
Db.PIF.set_MTU ~__context ~self:pif ~value:mtu
with _ ->
warn "could not update MTU field on PIF %s" rc.API.pIF_uuid
)

let bring_pif_down ~__context ?(force=false) (pif: API.ref_PIF) =
with_local_lock (fun () ->
Expand Down