Skip to content

Conversation

gaborigloi
Copy link
Contributor

And test Valid_ref_list using alcotest.

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

@gaborigloi
Copy link
Contributor Author

This depends on xs-opam being released.

)

(alias
((name runalcotest)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make both of these run as part of runtest if you put alcotest in another folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://discuss.ocaml.org/t/jbuilder-support-for-multiple-test-executables/825 you can in fact have two runtest in same jbuild file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's great, I'll use two!

And test Valid_ref_list using alcotest.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
@lindig
Copy link
Contributor

lindig commented Jan 19, 2018

xs-opam has been released. Can we merge this?

@mseri
Copy link
Contributor

mseri commented Jan 19, 2018

Let's rerun travis first, once we have a build with the next xs-opam uploaded to the xs-buildenv

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
@gaborigloi
Copy link
Contributor Author

Coveralls doesn't work yet

@mseri
Copy link
Contributor

mseri commented Jan 22, 2018

Same issue as message-switch... There is finally a plan upstream to fix the ppx_bisect/coverage situation. Until that is complete you only need to install by hand the test dependencies in the .coverage script. It's a matter of adding alcotest to the opam install -y bisect_ppx ... line:

opam install -y bisect_ppx ocveralls

We don't have the issue with oUnit because until we rationalise the build, it is considered a required dependency and not a test one.

@gaborigloi
Copy link
Contributor Author

How about using opam install --build-test?

@mseri
Copy link
Contributor

mseri commented Jan 22, 2018

Let's try it. It did not work when I tried on message-switch, in that case I even tried setting the variables and installing bisect before running it trying to avoid running the tests twice (once by opam and the other for the coverage) but without much success

@gaborigloi
Copy link
Contributor Author

Oh, that doesn't work because that tries to install the test deps of the dependencies transitively

This is a required dependency for testing.
We cannot use the "opam install --build-test" flag because it seems that
transitively installs the test dependencies of xapi's dependencies, and
we don't have all of those in xs-opam apparently.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 17.659% when pulling 0aa2e31 on gaborigloi:alcotest into 818b7e0 on xapi-project:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants