-
Notifications
You must be signed in to change notification settings - Fork 292
Add suite with alcotest #3402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suite with alcotest #3402
Conversation
This depends on xs-opam being released. |
ocaml/xapi/jbuild
Outdated
) | ||
|
||
(alias | ||
((name runalcotest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can make both of these run as part of runtest if you put alcotest in another folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://discuss.ocaml.org/t/jbuilder-support-for-multiple-test-executables/825 you can in fact have two runtest
in same jbuild file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's great, I'll use two!
And test Valid_ref_list using alcotest. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
xs-opam has been released. Can we merge this? |
Let's rerun travis first, once we have a build with the next |
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Coveralls doesn't work yet |
Same issue as xen-api/.travis-opam-coverage.sh Line 36 in e50f875
We don't have the issue with |
How about using |
Let's try it. It did not work when I tried on message-switch, in that case I even tried setting the variables and installing bisect before running it trying to avoid running the tests twice (once by opam and the other for the coverage) but without much success |
Oh, that doesn't work because that tries to install the test deps of the dependencies transitively |
This is a required dependency for testing. We cannot use the "opam install --build-test" flag because it seems that transitively installs the test dependencies of xapi's dependencies, and we don't have all of those in xs-opam apparently. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
And test Valid_ref_list using alcotest.
Signed-off-by: Gabor Igloi gabor.igloi@citrix.com