Convert Test_daemon_manager, Test_agility, Test_basic to Alcotest #3480
Conversation
| let __context = Mock.make_context_with_new_db "Mock context" in | ||
| let licensed = try Xapi_vm_migrate.assert_licensed_storage_motion ~__context; true | ||
| with _ -> false in | ||
| assert_bool "Not licensed for SXM" licensed |
There was a problem hiding this comment.
Is this test no longer valid or is this function tested elsewhere?
There was a problem hiding this comment.
I decided to simply delete this because it was not run: at line 32, we have skip "TODO"
There was a problem hiding this comment.
Is it worth removing the skip "TODO" so it runs and including it?
There was a problem hiding this comment.
I don't know whether it works or not, but probably not because it was skipped. My thinking was that it's probably not worth trying to debug old legacy tests 🤔
There was a problem hiding this comment.
FYI all the tests in Test_basic are really just demo tests that were written when unit tests first became a thing - they're not particularly useful as actual tests of the xapi codebase.
There was a problem hiding this comment.
Oh ok, thanks a lot for the info @johnelse - then I'll just remove it completely 😄
| assert_equal !Mock_daemon.times_called_stop 1 | ||
| Alcotest.(check int) "times_called_start" !Mock_daemon.times_called_start 0; | ||
| Alcotest.(check int) "time_until_stopped" !Mock_daemon.times_called_stop 1 | ||
|
|
There was a problem hiding this comment.
I notice that lines 142-143 are repeated 7 times with different numbers, is it worth making an alias function?
There was a problem hiding this comment.
Sounds good, done
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
These are just some demo unit tests that do not tests any useful functionality of our code. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
We've recently started porting xapi's unit tests from OUnit, to Alcotest.
In #3402 we've added support for unit testing xapi using alcotest. Now there are two suites, one using ounit and another one using alcotest. New unit tests should use alcotest.
Moving to alcotest is beneficial because it has better output, thereby reducing log spam and making it easier to fix and write unit tests, and is probably lighter, more actively maintained, and more commonly used.
To get the full benefits of alcotest, we'd have to port all of our unit tests to it.
This PR ports some xapi unit tests from OUnit to Alcotest.
Useful links:
Signed-off-by: Gabor Igloi gabor.igloi@citrix.com