Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dedicated ZFS SR driver to avoid losing VDI metadata #401

Closed
stormi opened this issue Jun 15, 2020 · 0 comments
Closed

Create a dedicated ZFS SR driver to avoid losing VDI metadata #401

stormi opened this issue Jun 15, 2020 · 0 comments
Assignees
@Wescoeur
Labels
bug 🐛

Comments

@stormi
Copy link
Member

stormi commented Jun 15, 2020 •
edited
Loading

Currently, we allow mounting ZFS through the file SR driver, which is convenient because it does not need to know how the data is mounted into the directory.

However, that driver cannot detect the situation when the mountpoint is empty because of a (temporary) mount failure, such as what happened to a user who switched to the alternate kernel (which doesn't provide a ZFS driver) for a test. The SR driver sees an empty directory and considers that here are no VDIs anymore in the SR. So it forgets about all those VDIs. Once they are seen again during a later scan, all the metadata about them is lost.

There are built-in protections against this in the file SR driver for common mountpoints, but ZFS doesn't use such mount points as far as I can tell, so the protection didn't work. Actually the protections are not on when the SR type is file.

A dedicated driver may also include ZFS-specific features (e.g. using ZFS snapshots for snapshots?), but the exact behaviour of the driver is yet to be decided. Maybe start with a zfsbasic driver just for fixing the "VDI disappearing" bug?
@stormi stormi changed the title Create a dedicated ZFS SR driver Create a dedicated ZFS SR driver to avoid losing VDI metadata Jun 15, 2020
@stormi stormi mentioned this issue Jun 15, 2020
Closed
@stormi stormi mentioned this issue Jul 10, 2020
Closed
13 tasks
@Wescoeur Wescoeur self-assigned this Jul 22, 2020
Wescoeur added a commit to xcp-ng/sm that referenced this issue Aug 12, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
0a7a377 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Aug 12, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
f01b66b 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Aug 12, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
ea4a13e 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Aug 13, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
7671ada 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Aug 13, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
353bf5d 
…p#401)
stormi pushed a commit to xcp-ng/sm that referenced this issue Aug 17, 2020
@Wescoeur @stormi
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
85121aa 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Sep 18, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
079d45e 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Sep 18, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
8e57622 
…p#401)
@stormi stormi closed this as completed Sep 28, 2020
Wescoeur added a commit to xcp-ng/sm that referenced this issue Nov 6, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
1bd6a94 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Nov 6, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
2d58435 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Dec 14, 2020
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
e4f2f8d 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Jan 11, 2021
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
e6771e2 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Apr 28, 2021
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
3d3aeb9 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Apr 29, 2021
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
6676273 
…p#401)
xandrus pushed a commit to xandrus/sm that referenced this issue May 4, 2021
@Wescoeur @xandrus
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
363937b 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue May 27, 2021
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
89bd6a4 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue May 27, 2021
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
08f6680 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Jun 22, 2021
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
f7beb99 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Jan 4, 2022
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
2392fe5 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Jun 14, 2022
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
02126f7 
…p#401)
andrey-podko pushed a commit to andrey-podko/sm that referenced this issue Aug 16, 2022
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
317eb06 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Sep 1, 2022
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
27e9e3c 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Dec 8, 2022
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
9ccfd1e 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Dec 8, 2022
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
f884719 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Mar 6, 2023
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
b53dc7e 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Mar 6, 2023
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
a63b322 
…p#401)
ydirson pushed a commit to xcp-ng/sm that referenced this issue Mar 27, 2023
@Wescoeur @ydirson
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
005a677 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Apr 17, 2023
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
335aded 
…p#401)
ydirson pushed a commit to xcp-ng/sm that referenced this issue Apr 20, 2023
@Wescoeur @ydirson
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
93f2c03 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Apr 25, 2023
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
9cb3f67 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Jul 31, 2023
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
b1f4dd1 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Sep 18, 2023
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
eb0b312 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Sep 18, 2023
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
c918977 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Sep 18, 2023
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
66ded63 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Oct 13, 2023
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
dbfbe5f 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Dec 11, 2023
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
5d3a638 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Jan 23, 2024
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
db32b49 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Feb 6, 2024
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
f2d0f04 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Apr 10, 2024
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
a1757cb 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Apr 11, 2024
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
60b7c4b 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Jun 12, 2024
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
4525a55 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Jun 24, 2024
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
b0bf49a 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 12, 2024
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
7f48869 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 13, 2024
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
29a2f38 
…p#401)
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 13, 2024
@Wescoeur @benjamreis
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
cd3cd24 
…p#401)
Wescoeur added a commit to xcp-ng/sm that referenced this issue Oct 3, 2024
@Wescoeur
feat(drivers): add ZFS driver to avoid losing VDI metadata (xcp-ng/xc…
3a948fe 
…p#401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wescoeur Wescoeur

Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stormi @Wescoeur