Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Version in Title #17

Closed
borzel opened this issue Apr 10, 2018 · 2 comments
Closed

Show Version in Title #17

borzel opened this issue Apr 10, 2018 · 2 comments
Labels
question Further information is requested

Comments

@borzel
Copy link
Member

borzel commented Apr 10, 2018 •
edited
Loading

Would this be helpfull?
@borzel borzel added the question Further information is requested label Apr 10, 2018
@cocoon
Copy link
Collaborator

cocoon commented Apr 11, 2018

Maybe not in the title, one thing I could think of are automated scripts that target a window by title like here: https://www.autoitscript.com/autoit3/docs/functions/WinGetHandle.htm

But the AssemblyFileVersion might be a good place to be filled so that if you right click one of the files and select the properties go to the details tab that you can see a version instead of 0.0.0.0:
https://github.com/xcp-ng/xenadmin/blob/release-7.4.0.2/XenAdmin/Properties/AssemblyInfo.cs#L64

borzel added a commit that referenced this issue Apr 11, 2018
@borzel
Fill AssemblyFileVersion
525d4dd 
Idea from #17 Show Version in Title
@borzel borzel mentioned this issue Apr 11, 2018
Closed
@borzel
Copy link
Member Author

borzel commented Apr 18, 2018

Seems not to be needed -> close

@borzel borzel closed this as completed Apr 18, 2018
borzel added a commit that referenced this issue May 27, 2018
@borzel
Integrade changes from master-7.4 into master (#68)
00eb9eb 
proper fix: use Path to TestDirectory

https://github.com/nunit/docs/wiki/Breaking-Changes

CurrentDirectory:
No longer set to the directory containing the test assembly. Use TestContext.CurrentContext.TestDirectory to locate that directory.
fix Test CertificateDialogTests

Path to the Cert was build as:
 xenadmin\TestResources\TestDevCertificate.cer

but should be:
 xenadmin\XenAdminTests\TestResources\TestDevCertificate.cer
fix Test TestFailingReaderGeneration

Ionic.BZip2 is throwing an IOException:
System.IO.IOException: 'Not a valid BZip2 stream. byte 0, expected '66', got '-1''
use update.xml in master brach on github (as a first solution)

#29

Do not check for ContainerCapability on XCP-ng, just belive in it :-)

If server is in not licenced, don't show alert icon

Changed SetUp to OneTimeSetup in SetUpFixture

#24

abort, if BUILD_NUMBER environment variable is not set

build automation

Ignore ".vs" folder
splash buildable with Visual Studio Community 2018

#24 Get Tests running

#24 Get Tests running

real world: edition "platinum" has changed to "desktop-plus"

#24 Get Tests running

set culture to "en-EN" to ensure correct parsing

#24 Get Tests running

correct adaption to nunit 3

adapt to nunit 3

adapt path

real world: edition "platinum" has changed to "desktop-plus"

Use Nunit and Moq from NuGet; Adapt tests to Nunit 3

#24 Get Tests running

Fill AssemblyFileVersion

Idea from #17 Show Version in Title

Tidy up Branding/Trademarks/License

#18

Comment unreachable code to be buildable (#14 (comment))

XCP-ng Console should connect to any flavor of XenServer

(cherry picked from commit 7e23425)
borzel pushed a commit that referenced this issue May 30, 2018
@Fungusware @borzel
Complete Patchset for XenAdmin --> XCP-ng Center
1e8da62 
- branding
- custom msi installer
- upgrade from NUnit2 to NUnit3

#70

build all projects in Release; Restore per nuget.exe

Restore Nuget-packages with nuget.exe

#65

Restore Nuget-packages

#65

Remove invalid characters from ComponentGroupRef

#69

Release: just build the projects needed to create the installer

let prebuild script work in Release AND Debug

add path to release files

don't set buildnumber to 1
#69

Integrade master-7.4 into master - tidy up
#68

Integrade changes from master-7.4 into master (#68)

proper fix: use Path to TestDirectory

https://github.com/nunit/docs/wiki/Breaking-Changes

CurrentDirectory:
No longer set to the directory containing the test assembly. Use TestContext.CurrentContext.TestDirectory to locate that directory.
fix Test CertificateDialogTests

Path to the Cert was build as:
 xenadmin\TestResources\TestDevCertificate.cer

but should be:
 xenadmin\XenAdminTests\TestResources\TestDevCertificate.cer
fix Test TestFailingReaderGeneration

Ionic.BZip2 is throwing an IOException:
System.IO.IOException: 'Not a valid BZip2 stream. byte 0, expected '66', got '-1''
use update.xml in master brach on github (as a first solution)

#29

Do not check for ContainerCapability on XCP-ng, just belive in it :-)

If server is in not licenced, don't show alert icon

Changed SetUp to OneTimeSetup in SetUpFixture

#24

abort, if BUILD_NUMBER environment variable is not set

build automation

Ignore ".vs" folder
splash buildable with Visual Studio Community 2018

#24 Get Tests running

#24 Get Tests running

real world: edition "platinum" has changed to "desktop-plus"

#24 Get Tests running

set culture to "en-EN" to ensure correct parsing

#24 Get Tests running

correct adaption to nunit 3

adapt to nunit 3

adapt path

real world: edition "platinum" has changed to "desktop-plus"

Use Nunit and Moq from NuGet; Adapt tests to Nunit 3

#24 Get Tests running

Fill AssemblyFileVersion

Idea from #17 Show Version in Title

Tidy up Branding/Trademarks/License

#18

Comment unreachable code to be buildable (#14 (comment))

XCP-ng Console should connect to any flavor of XenServer

(cherry picked from commit 7e23425)

More future-proof installer/updater
- rename ~~XenCenter~~ properly in branding script

#35

More future-proof installer/updater

#35

Added XCP-ng_Installer Source Files

quotation marks for string with spaces

Fully buildable with Visual Studio Community 2017

(cherry picked from commit cacd02a)

Complete branding set

more general hotkey definition

Update FriendlyNames.ja.resx

Update FriendlyNames.zh-CN.resx

Update FriendlyNames.resx
borzel added a commit that referenced this issue Feb 9, 2019
@borzel
Integrade changes from master-7.4 into master (#68)
2d1f47c 
proper fix: use Path to TestDirectory

https://github.com/nunit/docs/wiki/Breaking-Changes

CurrentDirectory:
No longer set to the directory containing the test assembly. Use TestContext.CurrentContext.TestDirectory to locate that directory.
fix Test CertificateDialogTests

Path to the Cert was build as:
 xenadmin\TestResources\TestDevCertificate.cer

but should be:
 xenadmin\XenAdminTests\TestResources\TestDevCertificate.cer
fix Test TestFailingReaderGeneration

Ionic.BZip2 is throwing an IOException:
System.IO.IOException: 'Not a valid BZip2 stream. byte 0, expected '66', got '-1''
use update.xml in master brach on github (as a first solution)

#29

Do not check for ContainerCapability on XCP-ng, just belive in it :-)

If server is in not licenced, don't show alert icon

Changed SetUp to OneTimeSetup in SetUpFixture

#24

abort, if BUILD_NUMBER environment variable is not set

build automation

Ignore ".vs" folder
splash buildable with Visual Studio Community 2018

#24 Get Tests running

#24 Get Tests running

real world: edition "platinum" has changed to "desktop-plus"

#24 Get Tests running

set culture to "en-EN" to ensure correct parsing

#24 Get Tests running

correct adaption to nunit 3

adapt to nunit 3

adapt path

real world: edition "platinum" has changed to "desktop-plus"

Use Nunit and Moq from NuGet; Adapt tests to Nunit 3

#24 Get Tests running

Fill AssemblyFileVersion

Idea from #17 Show Version in Title

Tidy up Branding/Trademarks/License

#18

Comment unreachable code to be buildable (#14 (comment))

XCP-ng Console should connect to any flavor of XenServer

(cherry picked from commit 7e23425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cocoon @borzel