Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Traits #272

Closed
xdy opened this issue Jan 3, 2021 · 4 comments · Fixed by #1197
Closed

Implement Traits #272

xdy opened this issue Jan 3, 2021 · 4 comments · Fixed by #1197

Comments

@xdy
Copy link
Owner

xdy commented Jan 3, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Needed to handle both alien species and things like https://www.drivethrurpg.com/product/262129/Cepheus-Light-Traits (which will be included by default in the next edition of Cepheus Light).
JOAT can also be handled this way, see #57
Basically, if something is innate to a character, but is neither a skill nor a psionic power, it should probably be a trait.

Describe the solution you'd like
Add a new item type 'trait', that would have 'key','name','level','description' to start with. Then add them to the character sheet (probably a new tab, possibly a new list below skills).

This is intended to support all 'this character breaks a particular rule' situations.
In the long run these (along with items) should also have Active Effects.

Describe alternatives you've considered
Keep adding ad hoc comments in Notes.

Additional context
https://www.orffenspace.com/cepheus-srd/character-creation.html
https://www.drivethrurpg.com/product/262129/Cepheus-Light-Traits
@xdy xdy mentioned this issue Jan 3, 2021
Closed
@jonepatr
Copy link
Collaborator

jonepatr commented Jan 6, 2021

Could this be a way to handle weapon traits as well?

@xdy
Copy link
Owner Author

xdy commented Jan 7, 2021

That is indeed what the "traits":[] line in gearTemplate in template.json was intended for, though it's never been used.
And, now that I look at it, CL has weapon aspects, not traits, so I guess the "traits" on gear should be removed and replaced with "aspects" instead. For CL rate of fire should be removed, and replaced with looking at 'level' in the 'AUTO' aspect, if any.
I'll make an issue for the above.

@jonepatr jonepatr added this to the 0.8 milestone Jan 20, 2021
@jonepatr
Copy link
Collaborator

Would this be a good place to use the active effects?

@xdy xdy mentioned this issue Feb 26, 2021
Open
@marvin9257 marvin9257 mentioned this issue Sep 6, 2021
Closed
2 tasks
@marvin9257
Copy link
Collaborator

We can close this one, I think.

jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Dec 29, 2021
@jonepatr
feature: traits are now active effects
c1b9fb3 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
@jonepatr jonepatr mentioned this issue Dec 29, 2021
Closed
2 tasks
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Dec 29, 2021
@jonepatr
feature: traits are now active effects
b7524de 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Dec 29, 2021
@jonepatr
feature: traits are now active effects
2cb9f69 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Dec 29, 2021
@jonepatr
feature: traits are now active effects
745c3ae 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 2, 2022
@jonepatr
feature: traits are now active effects
05dd28b 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 3, 2022
@jonepatr
feature: traits are now active effects
42c91ca 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 3, 2022
@jonepatr
feat: traits are now active effects
c735dc4 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 4, 2022
@jonepatr
feat: traits are now active effects
f9fea15 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 7, 2022
@jonepatr
feat: traits are now active effects
ff77e38 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 9, 2022
@jonepatr
feat: traits are now active effects
3e0d9d7 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 12, 2022
@jonepatr
feat: traits are now active effects
e5d29c0 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
@jonepatr jonepatr removed this from the 0.8 milestone Jan 13, 2022
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 13, 2022
@jonepatr
feat: traits are now active effects
47c4aa2 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 14, 2022
@jonepatr
feat: traits are now active effects
039a3f4 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 20, 2022
@jonepatr
feat: traits are now active effects
1e11bec 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Jan 21, 2022
@jonepatr
feat: traits are now active effects
85788cb 
Previsouly adding a trait did not affect the actor. This change makes
it so that a trait is an active effect and can change the
actor.

Fix xdy#272
@marvin9257 marvin9257 linked a pull request Jan 6, 2023 that will close this issue
feat: Redo of active effects #1197
Merged
2 tasks
@marvin9257 marvin9257 removed a link to a pull request Jan 24, 2023
feat: Redo of active effects #1197
Merged
2 tasks
@marvin9257 marvin9257 linked a pull request Jan 24, 2023 that will close this issue
feat: Redo of active effects #1197
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Redo of active effects marvin9257/twodsix-foundryvtt
3 participants
@xdy @jonepatr @marvin9257