Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actor traits #606

Closed
wants to merge 8 commits into from
Closed

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Sep 6, 2021

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add feature - allow actors to have traits. This addresses issue Implement Traits #272

  • What is the current behavior? (You can also link to an open issue here)

No ability to use traits other than in actor notes

  • What is the new behavior (if this is a feature change)?

Creates a new item type - trait - that shows on actor info tab.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

I don't think so - but there will be some missing translations

  • Other information:

@marvin9257 marvin9257 changed the title WIP: Add actor traits Add actor traits Sep 6, 2021
@marvin9257
Copy link
Collaborator Author

marvin9257 commented Sep 6, 2021

This is the first time changing the HTML and CSS files. So please check my homework. I can't find any errors.

@xdy
Copy link
Owner

xdy commented Sep 25, 2021

Added a fix to en.json and merged manually, so closing.

@xdy xdy closed this Sep 25, 2021
@marvin9257 marvin9257 deleted the add-actor-traits branch September 25, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants