XCD-109 Snapping change of a measurement in progress #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se,Touch}Control in progress
MichalDybizbanskiCreoox
force-pushed
the
XCD-109-measurement-in-progress-change-snap
branch
from
da40251
to
433987a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes semantics of the
{Angle,Distance}Measurements{Mouse,Touch}Control::snappingchange while a measurement is partially created.Specifically the PR prevents resetting the creation process on
snappingchange, which means thatsnappingchange will keep a partial measurement intact.This allows some of a measurement's endpoints to be places with snapping, and some without.
This PR also fixes the XEOK-46 regression.