99-KMP.Database. #110

bogdan-evtushenko · 2020-03-13T09:52:17Z

No description provided.

yev-kanivets

Works like a charm 👍See comments for some questions / remarks.

app/build.gradle

    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.2"

    implementation "com.squareup.okhttp3:logging-interceptor:4.2.1"
+    implementation "com.squareup.sqldelight:android-driver:1.2.1"


app/schemas/com.bogdan.codeforceswatcher.room.AppDatabase/4.json

@@ -0,0 +1,80 @@
+{


app/src/main/java/com/bogdan/codeforceswatcher/features/problems/ProblemActivity.kt

    private lateinit var pageTitle: String
    private lateinit var link: String

+    private val problem: Problem


app/src/main/java/com/bogdan/codeforceswatcher/features/users/redux/requests/UsersRequests.kt

                        }
                    }
-                    DatabaseClient.userDao.update(user)
+                    withContext(Dispatchers.IO) {


common/build.gradle


        jvmMain {
            dependencies {
-                api "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"


common/src/commonMain/kotlin/io/xorum/codeforceswatcher/features/problems/models/Problem.kt

+) {
+    fun identify() = "$contestId$index"
+
+    fun copy(id: Long = this.id, name: String = this.name, enName: String = this.enName, ruName: String = this.ruName, index: String = this.index, contestId: Long = this.contestId, contestName: String = this.contestName, contestTime: Long = this.contestTime, isFavourite: Boolean = this.isFavourite) =


common/src/commonMain/kotlin/io/xorum/codeforceswatcher/features/problems/models/Problem.kt

+import kotlinx.serialization.Serializable
+
+@Serializable
+class Problem(


common/src/commonMain/kotlin/redux/AppStore.kt

+
+lateinit var sqlDriver: SqlDriver
+
+/*val store = Store(


yev-kanivets · 2020-03-13T12:32:59Z

common/src/commonMain/sqldelight/io/xorum/codeforceswatcher/1.sqm

@@ -0,0 +1 @@
+CREATE TABLE Contest (id INTEGER NOT NULL, name TEXT NOT NULL, time INTEGER NOT NULL, phase TEXT NOT NULL, PRIMARY KEY(id))


If migrations doesn't work in the current version, it's better to remove them.

Are you sure?

I wanted to say if migrations. But yes, I'm almost sure these migrations aren't needed. Can you check?

They work, otherwise, how I install application to old version db and everything work?

yev-kanivets · 2020-03-13T12:34:21Z

common/src/commonMain/sqldelight/io/xorum/codeforceswatcher/User.sq

+SELECT * FROM User;
+
+insert:
+INSERT OR REPLACE INTO User(avatar, rank, handle, rating, maxRating, firstName, lastName, ratingChanges) VALUES(?,?,?,?,?,?,?,?);


I've see that you have if for 2 inserts, but they both are INSERT OR REPLACE, so not sure you can't get rid of one.

The first one really insert User, second one - update. They are different, because second one have 'id' parametre, unlike first one.

yev-kanivets

Good job 👍

bogdan-evtushenko and others added 7 commits March 4, 2020 15:18

#99. Connect SQLDelight to Room.

91fe2db

#99; Resolve path issues.

549deeb

#99. Migrate SQLDelight to Room.

6af585f

#99; Apply kotlin-multiplatform plugin to android module.

85ef1de

#99. Fix bugs and speed up queries in SQLDelight.

10efd0e

#99. Fix installation SQLDelight db to already installed Room db.

f3aa69f

#99. Fix lagging while users fetching.

4095507

bogdan-evtushenko requested a review from yev-kanivets March 13, 2020 09:52

bogdan-evtushenko self-assigned this Mar 13, 2020

Merge branch 'dev' into 99-kmp

f16b3f9

yev-kanivets reviewed Mar 13, 2020

View reviewed changes

yev-kanivets and others added 2 commits March 13, 2020 15:10

#99; Rename table User to DbUser.

892d851

#99. Database. Add review fixes.

c08bb2e

yev-kanivets approved these changes Mar 13, 2020

View reviewed changes

bogdan-evtushenko merged commit ed9cc3c into dev Mar 13, 2020

bogdan-evtushenko deleted the 99-kmp branch March 20, 2020 09:25

		@@ -0,0 +1 @@
		CREATE TABLE Contest (id INTEGER NOT NULL, name TEXT NOT NULL, time INTEGER NOT NULL, phase TEXT NOT NULL, PRIMARY KEY(id))

99-KMP.Database. #110

99-KMP.Database. #110

Uh oh!

Conversation

bogdan-evtushenko commented Mar 13, 2020

Uh oh!

yev-kanivets left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

yev-kanivets Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bogdan-evtushenko Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

yev-kanivets Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

bogdan-evtushenko Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

yev-kanivets Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

bogdan-evtushenko Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yev-kanivets left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yev-kanivets Mar 13, 2020 •

edited

Loading

bogdan-evtushenko Mar 13, 2020 •

edited

Loading