Skip to content

Commit d08b628

Browse files
committed
Make master green again
The new Rust compiler got a lot smarter at spotting "dead code" and started complaining about some unused bits. Turns out the snippet update feature was never fully finished — but that’s no reason to rip out parts of the storage subsystem. On top of that, GitHub CI switched to a new macOS runner that doesn’t come with PostgreSQL pre-installed anymore. So we had to bump the action-setup-postgres version to get it running smoothly.
1 parent 9dedaa6 commit d08b628

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
override: true
7474

7575
- name: Setup PostgreSQL
76-
uses: ikalnytskyi/action-setup-postgres@v6
76+
uses: ikalnytskyi/action-setup-postgres@v7
7777

7878
- id: detect_host
7979
run: |

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
override: true
7878

7979
- name: Setup PostgreSQL
80-
uses: ikalnytskyi/action-setup-postgres@v6
80+
uses: ikalnytskyi/action-setup-postgres@v7
8181
id: postgres
8282

8383
- name: Set ROCKET_DATABASE_URL
@@ -127,7 +127,7 @@ jobs:
127127
override: true
128128

129129
- name: Setup PostgreSQL
130-
uses: ikalnytskyi/action-setup-postgres@v6
130+
uses: ikalnytskyi/action-setup-postgres@v7
131131
id: postgres
132132

133133
- run: |

src/storage/sql/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ impl Storage for SqlStorage {
303303
Ok(snippet)
304304
}
305305

306+
#[allow(dead_code)]
306307
async fn update(&self, snippet: &Snippet) -> Result<Snippet, StorageError> {
307308
// load the snippet from the db to check if we need to update anything
308309
let persisted_state = self.get(&snippet.id).await?;

src/web/tracing.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ impl Fairing for RequestIdHeader {
6464
/// A natural point of integration with Rocket is a fairing, which allows us to
6565
/// execute some code before and after each HTTP request, which is exactly what
6666
/// we need for determining the boundaries of a request span.
67+
#[allow(dead_code)]
6768
pub struct RequestSpan;
6869

6970
// TODO: Now that Rocket is using async internally, this is not guaranteed to

0 commit comments

Comments
 (0)