Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consolidate conditional branches in node-deep-equal() #1426

Merged
merged 2 commits into from
May 8, 2021
Merged

refactor: consolidate conditional branches in node-deep-equal() #1426

merged 2 commits into from
May 8, 2021

Conversation

AirQuick
Copy link
Member

Just consolidate two conditional branches in node-deep-equal() into one.

@AirQuick AirQuick added this to the v2.2 milestone Mar 30, 2021
galtm
galtm approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AirQuick AirQuick enabled auto-merge (squash) May 8, 2021 12:53
@AirQuick AirQuick merged commit 6b39fb1 into xspec:master May 8, 2021
@AirQuick AirQuick deleted the consolidate-branches-node-deep-equal branch May 8, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galtm galtm galtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AirQuick @galtm