Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Saxon 12 to CI matrix #1745

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

AirQuick
Copy link
Member

This pull request adds Saxon 12.1 to GitHub Actions and Azure Pipelines.

  • macOS is skipped (to save resource), because Saxon 12 is not considered as stable (yet).
  • Java 8 is skipped, because Saxon 12 does not actively support it.
  • Saxon 12.2 should be skipped, due to its critical bug.

Some minor tests are failing

I haven't looked into them. They should be investigated in the future. (Any contributions for fixing them are welcome.)
Currently, those failing tests are skipped by undefining SAXON12_INITIAL_ISSUES_FIXED in Bats tests or setting require-saxon-12-initial-issues-fixed in Ant-driven tests.
Since they don't look like critical tests, I don't think they block v2.3 release.

@AirQuick AirQuick added the test label Jun 13, 2023
@AirQuick AirQuick added this to the v2.3 milestone Jun 13, 2023
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'll start looking into the minor failures in the coming week and see how far I get.

@AirQuick AirQuick enabled auto-merge (squash) June 16, 2023 16:35
@AirQuick AirQuick merged commit 673d5d7 into xspec:master Jun 16, 2023
@AirQuick AirQuick deleted the test_saxon-12-1 branch June 16, 2023 17:30
@AirQuick
Copy link
Member Author

Merged this and added the Saxon 12 tests to Required Checks.

Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial results of investigating Saxon 12 initial issues

test/win-bats/collection.xml Show resolved Hide resolved
test/external_global-context_stylesheet.xspec Show resolved Hide resolved
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More notes on the test failures...

test/win-bats/collection.xml Show resolved Hide resolved
test/win-bats/collection.xml Show resolved Hide resolved
test/win-bats/collection.xml Show resolved Hide resolved
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that Saxon 12.4 fixes certain issues seen in earlier 12.x versions

test/win-bats/collection.xml Show resolved Hide resolved
test/win-bats/collection.xml Show resolved Hide resolved
test/win-bats/collection.xml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants