Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and comment for handling whitespace-only text node #571

Merged
merged 1,308 commits into from
Jul 29, 2019

Conversation

AirQuick
Copy link
Member

This pull request derives from #566. So needs to be handled after that.


This pull request is a follow-up change regarding #459 (review)

Commits

  • c711616 adds a test for whitespace-only text node appearing immediately in user-content
  • afd4a1f adds a comment for mode=test:generate-variable-declarations regarding whitespace-only text node

# Conflicts:
#	test/end-to-end/cases/expected/query/xspec-153-result.html
# Conflicts:
#	test/generate-tests-utils.xspec
# Conflicts:
#	test/end-to-end/cases/expected/query/xspec-67-result.html
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/xspec-67.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
# Conflicts:
#	test/generate-tests-utils.xspec
# Conflicts:
#	test/win-bats/collection.xml
#	test/xspec.bats
# Conflicts:
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
…01-22

# Conflicts:
#	.travis.yml
#	appveyor.yml
This reverts commit e67a373.
…t-css-uri

# Conflicts:
#	bin/xspec.bat
#	bin/xspec.sh
#	src/common/xspec-utils.xsl
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-tests.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schematron/schut-to-xspec.xsl
#	test/ant/build.xml
#	test/ant/worker/build-worker_util.xml
#	test/ant/worker/generate.xsl
#	test/end-to-end/cases/expected/schematron/schematron-01-result.html
#	test/end-to-end/cases/expected/stylesheet/coverage-tutorial-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-153-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-50-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-55-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-67-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-focus-1-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-function-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-import-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-imported-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-pending-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-xslt2-result.html
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/xspec-utils.xspec
#	test/xspec.bats
This reverts commit cf6a80f.
# Conflicts:
#	src/reporter/format-xspec-report.xsl
#	test/end-to-end/cases/expected/stylesheet/xspec-serialize-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-result.html
…412_xquery

# Conflicts:
#	src/compiler/generate-common-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-report-junit.xml
#	test/end-to-end/cases/expected/query/xspec-report-result.html
#	test/end-to-end/cases/expected/query/xspec-report-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-report-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-report-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-report-result.xml
#	test/end-to-end/cases/xspec-report.xspec
@AirQuick AirQuick merged commit 190a64c into xspec:master Jul 29, 2019
@AirQuick AirQuick deleted the var-decl-with-ws-only-text branch July 29, 2019 19:34
@AirQuick
Copy link
Member Author

@cirulls
Merged this addition of a test and a comment.

Thanks @galtm for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants