Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): add hint link to result HTML #839

Merged
merged 5 commits into from
Mar 26, 2020

Conversation

AirQuick
Copy link
Member

To follow up #685 , this pull request adds a hint link (❔) to the upper right of the test result diff table (example). Not a beautiful one, but I hope it works.

@commit-lint
Copy link

commit-lint bot commented Mar 17, 2020

Features

Tests

  • update expected result of end-to-end test (eb24394)
  • update expected xspec-355-result.html (560593d)
  • xslt: update expected xspec-778_ws-result.html (5f02a6b)

Contributors

@AirQuick

Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I viewed sample reports in Chrome, Edge, and Firefox on Windows, with varying browser widths. The new icon looked fine in all cases. I think it will help people who are new to XSpec.

@AirQuick
Copy link
Member Author

Thanks @galtm for the review.
I'm merging this. The unfinished linked page will be tracked in #685.

@AirQuick AirQuick merged commit ed2ae30 into xspec:master Mar 26, 2020
@AirQuick AirQuick deleted the report-hint branch March 26, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants