support loading ooaofooa from zip archives #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Seems to fail on python3, see #16 and https://api.travis-ci.org/v3/job/566396780/log.txt |
|
I found the issue. The zipfile module in python 3.x opens the file as binary data and not text. Using io.TextIOWrapper resolves the difference. I found this here: https://stackoverflow.com/questions/5627954/how-do-you-read-a-file-inside-a-zip-file-as-text-not-bytes/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xtUML metamodel can be loaded from a set of file or directory resources. Allow zip archives to be loaded as well. The behavior is the same as directories where any file that uses the .xtuml file extension within the archive will be loaded.