Ensure that newly-added widgets don't get stripped from sidebar upon save #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added a commit
that referenced
this pull request
Dec 17, 2015
…d-sidebar-js-value Ensure that newly-added widgets don't get stripped from sidebar upon save
westonruter
deleted the
bugfix/include-new-widgets-in-sanitized-sidebar-js-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new widget to a sidebar, the widget ID was getting stripped from the
sidebars_widgetsoption when calling\WP_Customize_Widgets::sanitize_sidebar_widgets_js_instance()because the new widget ID was not among the$wp_registered_widgets.In Core, widgets should get registered if they get saved. The reason they were not registered is because it is
customize_saverequest, and sopreviewdoes not apply.