Skip to content

Ensure that newly-added widgets don't get stripped from sidebar upon save #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Ensure that newly-added widgets don't get stripped from sidebar upon save #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions php/class-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,38 @@ public function _flag_saved_setting_value( \WP_Customize_Setting $setting ) {
$this->saved_setting_values[ $setting->id ] = null;
}

/**
* Register any widgets that that get saved so that they will not get stripped
* out when \WP_Customize_Widgets::sanitize_sidebar_widgets_js_instance() is called.
*
* @todo In Core, \WP_Customize_Widgets should register any widget that gets saved.
*
* @param \WP_Customize_Manager $wp_customize Customize manager.
* @param array $saved_setting_ids Saved setting IDs.
*/
public function register_widgets_for_saved_settings( $wp_customize, $saved_setting_ids ) {
global $wp_registered_widgets;

foreach ( $saved_setting_ids as $setting_id ) {
$parsed_setting_id = $wp_customize->widgets->parse_widget_setting_id( $setting_id );
if ( is_wp_error( $parsed_setting_id ) ) {
continue;
}
$widget_id = $parsed_setting_id['id_base'];
if ( $parsed_setting_id['number'] ) {
$widget_id .= '-' . $parsed_setting_id['number'];
}

/*
* For the purposes of \WP_Customize_Widgets::sanitize_sidebar_widgets_js_instance()
* all we need to do is make sure that the array key exists for the given widget ID.
*/
if ( ! isset( $wp_registered_widgets[ $widget_id ] ) ) {
$wp_registered_widgets[ $widget_id ] = null;
}
}
}

/**
* Gather the saved setting values.
*
Expand All @@ -193,6 +225,8 @@ public function _flag_saved_setting_value( \WP_Customize_Setting $setting ) {
*/
public function gather_saved_setting_values( \WP_Customize_Manager $wp_customize ) {
$setting_ids = array_keys( $this->saved_setting_values );
$this->register_widgets_for_saved_settings( $wp_customize, $setting_ids );

foreach ( $setting_ids as $setting_id ) {
$setting = $wp_customize->get_setting( $setting_id );
if ( $setting ) {
Expand Down