Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and update dependencies #103

Merged
merged 8 commits into from
Dec 1, 2016
Merged

Clean up and update dependencies #103

merged 8 commits into from
Dec 1, 2016

Conversation

cdeszaq
Copy link
Collaborator

@cdeszaq cdeszaq commented Nov 19, 2016

No description provided.

@cdeszaq cdeszaq added the WIP label Nov 19, 2016
@cdeszaq cdeszaq modified the milestone: v0.7.x Nov 28, 2016
archolewa
archolewa requested changes Nov 28, 2016
View reviewed changes
CHANGELOG.md
codes not included in `Response.Status`.
codes not included in `Response.Status`.

- [Removed "provided" modifier for SLF4J and Logback dependencies in the Wikipedia example](https://github.com/yahoo/fili/pull/102)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we put new stuff at the bottom or the top of the CHANGELOG? Because I've been putting them at the top...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really matter. Git seems to complain less about merge conflicts if it's at the bottom I think.

CHANGELOG.md
- Breaking API changes:
- Moved config classes to own package
- Moved core classes to api package
- Moved to Redisson's RFuture instead of netty's Future
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These (starting at line 52) should be indented one more level.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Updating

fili-system-config/src/main/java/com/yahoo/bard/webservice/config/LayeredFileSystemConfig.java
@@ -64,11 +64,6 @@
private final Properties runtimeProperties;

/**
* Loader pulls resources in from class path locations.
*/
private final ConfigResourceLoader loader = new ConfigResourceLoader();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is only used in the constructor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'm just moving it to be a local variable, since it's only used in 1 method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cdeszaq
Add changelog entry for PR 102
c96cc90
@cdeszaq
Clean up poms to have more consistent boilerplate
361b1f3
@cdeszaq
Add missing licenses to sub-modules
0993e43
@cdeszaq
Clean up LayeredFileSystemConfig: Make var local
80fa276
@cdeszaq
Update Apache commons-configuration dependency
996a3e4 
`Configuration.getList` return type changed, so updating to handle it
@cdeszaq
Update JodaTime dependency
eacde7f 
The error message for intervals changed in JodaTime, so there are changes to
correct the message to a more human-friendly one.

A PR has been raised against JodaTime to correct their message, but it is
unlikely to be merged due to JodaTime stability: https://github.com/JodaOrg/joda-time/pull/406/files
@cdeszaq
Update Reddison dependency
bc199c1 
Reddison packaging changed a bit, so files updated accordingly
@cdeszaq
Update dependencies
aac730a 
* [Gmaven plugin 1.4 -> 1.5](groovy/gmaven@gmaven-1.4...gmaven-1.5)
* [Guava 16.0.1 -> 20.0](https://github.com/google/guava/wiki/ReleaseHistory)
* [Jedis 2.7.2 -> 2.9.0](https://github.com/xetorthio/jedis/releases):
    - Geo command support and binary mode support
    - ZADD support
    - Ipv6 and SSL support
    - Other assorted feature and Redis support upgrades
* [Redisson 2.2.13 -> 3.1.0](https://github.com/redisson/redisson/blob/master/CHANGELOG.md):
    - Support for binary stream in and out of Reddison
    - Lots of features for distributed data structure capabilities
    - Can make fire-and-forget style calls in ack-response-only modes
    - Many fixes and improvements for PubSub features
    - Support for command timeouts
    - Fixed bug where connections did not always close when RedisClient shut down
    - Breaking API changes:
    - Moved config classes to own package
    - Moved core classes to api package
    - Moved to Redisson's RFuture instead of netty's Future
* [JodaTime 2.8.2 -> 2.9.6](http://www.joda.org/joda-time/installation.html):
    - Faster TZ parsing
    - Added `Interval.parseWithOffset`
    - GMT fix for JDK 8u60
    - Fixed Interval overflow bug
    - TZ data update from 2015g to 2016i
* [AsyncHttpClient 2.0.2 -> 2.0.24](https://github.com/AsyncHttpClient/async-http-client/milestones?state=closed):
    - Custom header separator fix
    - No longer double-wrapping CompletableFuture exceptions
* [Apache HttpClient 4.5 -> 4.5.2](https://archive.apache.org/dist/httpcomponents/httpclient/RELEASE_NOTES-4.5.x.txt):
    - Supports handling a redirect response to a POST request
    - Fixed deflate zlib header issue
* [RxJava 1.1.5 -> 1.2.2](https://github.com/ReactiveX/RxJava/releases):
    - Deprecate TestObserver in favor of TestSubscriber
* Spymemcached 2.12.0 -> 2.12.1
* [org.json 20141113 -> 20160810](https://github.com/stleary/JSON-java)
* [Maven release plugin 2.5 -> 2.5.3](https://issues.apache.org/jira/browse/MRELEASE/?selectedTab=com.atlassian.jira.jira-projects-plugin:changelog-panel):
    - Fixes `release:prepare` not committing pom.xml if not in the git root
    - Fixes version update not updating inter-module dependencies
    - Fixes version update failing when project is not a SNAPSHOT
* [Maven antrun plugin 1.7 -> 1.8](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317121&version=12330276)
* [Maven compiler plugin 3.3 -> 3.6.0](https://issues.apache.org/jira/browse/MCOMPILER/?selectedTab=com.atlassian.jira.jira-projects-plugin:changelog-panel):
    - Fix for compiler fail in Eclipse
* [Maven surefire plugin 2.17 -> 2.19.1](https://issues.apache.org/jira/browse/SUREFIRE/?selectedTab=com.atlassian.jira.jira-projects-plugin:changelog-panel):
    - Correct indentation for Groovy's power asserts
* [Maven javadoc plugin 2.10.3 -> 2.10.4](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12331967)
* [Maven site plugin 3.5 -> 3.6](https://issues.apache.org/jira/browse/MSite/?selectedTab=com.atlassian.jira.jira-projects-plugin:changelog-panel)
* [SLF4J 1.7.12 -> 1.7.21](http://www.slf4j.org/news.html):
    - Fixed to MDC adapter, leaking information to non-child threads
    - Better handling of ill-formatted strings
    - Cleaned up multi-thread consistency for LoggerFactory-based logger initializations
    - Closed a multi-threaded gap where early logs may be lost if they happened while SLF4J was initializing in a multi-threaded application
* [Logback 1.1.3 -> ](http://logback.qos.ch/news.html):
    - Child threads no longer inherit MDC values
    - AsyncAppender can be configured to never block
    - Fixed issue with variable substitution when the value ends in a colon
* [Apache Commons Lang 3.4 -> 3.5](https://commons.apache.org/proper/commons-lang/release-notes/RELEASE-NOTES-3.5.txt)
* [Apache Commons Configuration 1.6 -> 1.10](https://commons.apache.org/proper/commons-configuration/changes-report.html#a1.7):
    - Tightened getList's behavior if the list values are non-strings
    - MapConfiguration can be set to not trim values by default
    - CompositeConfiguration can now handle non-BaseConfiguration core configurations
    - `addConfiguration()` overload added to allow correcting inconsistent configuration compositing
* [Apache Avro 1.8.0 -> 1.8.1](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310911&version=12333322)
* [Spring Core 4.0.5 -> 4.3.4](https://docs.spring.io/spring/docs/4.3.x/spring-framework-reference/html/)
* [CGLib 3.2.0 -> 3.2.4](https://github.com/cglib/cglib/releases):
    - Optimizations and regression fixes
* [Objenesis 2.2 -> 2.4](http://objenesis.org/notes.html)
* Jersey 2.22 -> 2.24:
    - https://jersey.java.net/release-notes/2.24.html
    - https://jersey.java.net/release-notes/2.23.html
    - `@BeanParam` linking support fix
    - Declarative linking with Maps fixed
    - Async write ordering deadlock fix
* HK2 2.4.0-b31 -> 2.5.0-b05:
    - Necessitated by Jersey upgrade
* [JavaX Annotation API 1.2 -> 1.3](https://jcp.org/en/jsr/detail?id=250)
@archolewa
Copy link
Contributor

👍

@michael-mclawhorn
Copy link
Contributor

👍

@cdeszaq cdeszaq merged commit aac730a into master Dec 1, 2016
@cdeszaq cdeszaq deleted the cleanUpAndUpdateDependencies branch December 1, 2016 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archolewa archolewa archolewa requested changes

Assignees
No one assigned
Labels
MERGEABLE
Projects
None yet
Milestone
v0.7.x
Development

Successfully merging this pull request may close these issues.
3 participants
@cdeszaq @archolewa @michael-mclawhorn