Skip to content
This repository was archived by the owner on Jan 6, 2018. It is now read-only.

Conversation

@gpbl
Copy link
Contributor

@gpbl gpbl commented Feb 20, 2015

See #4, matches console.log('I have a (parenthesis)');

Sadly with regexp is not easy to match brackets inside brackets, so this will strip also:

console.log('hi'); doVeryImportantStuff();

so I'm not 100% sure if this is a good change.

@yahoocla
Copy link

CLA is valid!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f381d58 on gpbl:better-regexp into 3492700 on yahoo:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f381d58 on gpbl:better-regexp into 3492700 on yahoo:master.

@Vijar
Copy link
Contributor

Vijar commented Feb 20, 2015

Hmm...this side effect seems pretty bad. Let me experiment with recast over the weekend and if it doesn't work, we will stick with this method.

@Vijar
Copy link
Contributor

Vijar commented Jan 30, 2016

Fixed by #11

@Vijar Vijar closed this Jan 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants