Repository navigation
Typos: what's worth fixing? #15747
|
After #15740 I tried a different LLM and found a few more typos; I'm not sure which ones are worth fixing. Instead of another PR I'm putting my finds here1, with the hope that the answers to my questions will inform future typo hunters. 😀 but the LLM says those are translated. I imagine the translations would stay the same, but I suppose the inner workings of the translation system mean they'd have to be re-entered: not worth it? But on the other hand, these are the most player-facing of all of these typos. Unciv/tests/src/com/unciv/logic/automation/unit/WorkerAutomationTest.kt Lines 258 to 259 in d348bda I think I've seen complaints about comment-only PRs. Thoughts? Recieve should be receive (apparently I have been misspelling it for years), but this function is used in several places. As I don't even know Kotlin this would probably be someone else fixing it--if the whole "stable API" thing isn't more important. Same typo, this time just in test names: Which of the above are worth fixing? If it's more work than it's worth to review typo PRs, please say so! Footnotes
|
Replies: 2 comments 1 reply
|
I think none of these are important. But I'll merge them if you want |
|
"Swiching" - I'm so embarrassed. |
I think none of these are important. But I'll merge them if you want