Add new test cases #100
Merged
Add new test cases #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
reviewed
Dec 24, 2021
src/58MP.yaml
Outdated
| from: '@ingydotnet' | ||
| tags: edge flow mapping | ||
| yaml: | | ||
| {"x" |
There was a problem hiding this comment.
this is practically the same as https://github.com/yaml/yaml-test-suite/blob/main/src/4MUZ.yaml / https://github.com/yaml/yaml-test-suite/blob/main/src/5MUD.yaml
So maybe add it to the existing one.
perlpunk
reviewed
Dec 24, 2021
perlpunk
reviewed
Dec 24, 2021
src/2G84.yaml
Outdated
Comment on lines
18
to
20
| =VAL | | ||
| -DOC | ||
| -STR |
There was a problem hiding this comment.
these 3 lines should be removed
There was a problem hiding this comment.
Actually the whole tree entry can be removed then.
perlpunk
reviewed
Dec 24, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
perlpunk
reviewed
Dec 25, 2021
|
|
||
| - fail: true | ||
| yaml: | | ||
| -———»- |
There was a problem hiding this comment.
To be complete, maybe also the other cases should be tested like:
?———»-
:———»-
?———»:
:———»:
ingydotnet
force-pushed
the
new-test-cases
branch
from
6f81999
to
e174507
Compare
ingydotnet
force-pushed
the
new-test-cases
branch
from
7828e10
to
dd62106
Compare
ingydotnet
force-pushed
the
new-test-cases
branch
from
dd62106
to
c348517
Compare
perlpunk
reviewed
Dec 27, 2021
| from: '@ingydotnet' | ||
| tags: edge | ||
| yaml: | | ||
| {x |
There was a problem hiding this comment.
This one would also be a good candidate to include in 4MUZ maybe?
perlpunk
approved these changes
Dec 27, 2021
perlpunk
added a commit
that referenced
this pull request
Jan 8, 2022
perlpunk
added a commit
that referenced
this pull request
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.