Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enum comparisons #913

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Fix Enum comparisons #913

merged 3 commits into from
Aug 1, 2019

Conversation

imobachgs
Copy link
Contributor

Implement #== to compare BootProtocol and IpoibMode objects.

@imobachgs imobachgs force-pushed the network-ng-fix-enum-comparisons branch from c4c2d0e to 55a1594 Compare August 1, 2019 13:59
@coveralls
Copy link

coveralls commented Aug 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 64.688% when pulling ed5c3a3 on network-ng-fix-enum-comparisons into 4399f2a on network-ng.

teclator
teclator approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 6974a90 into network-ng Aug 1, 2019
@imobachgs imobachgs deleted the network-ng-fix-enum-comparisons branch August 1, 2019 14:46
@imobachgs imobachgs mentioned this pull request Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imobachgs @coveralls @teclator