Skip to content

fix(Overview): use definition list for external objects info #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

fix(Overview): use definition list for external objects info #3002

merged 1 commit into from
Oct 23, 2025

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Oct 23, 2025 •
edited by github-actions bot
Loading

There was some issue with location display, changed InfoViewer to DefinitionList, not it looks better

ExternalDataSource: https://nda.ya.ru/t/k_efKS7m7LnqZ7
ExternalTable: https://nda.ya.ru/t/Zpzy2-Oh7LnqcU

Before:
Screenshot 2025-10-23 at 11 53 57

After:
Screenshot 2025-10-23 at 12 04 04

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 374 0 2 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 45.87 MB | Main: 45.87 MB
Diff: 1.22 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov marked this pull request as ready for review October 23, 2025 10:17
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Oct 23, 2025

Skipped: This PR does not contain any of your configured keywords: (greptile-review)

@artemmufazalov artemmufazalov added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 34e428a Oct 23, 2025
6 checks passed
@artemmufazalov artemmufazalov deleted the definition-list-for-external-objects branch October 23, 2025 10:37
@ydb-platform-bot ydb-platform-bot mentioned this pull request Oct 23, 2025
Merged
@artemmufazalov artemmufazalov self-assigned this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raubzeug Raubzeug Raubzeug approved these changes

@astandrik astandrik Awaiting requested review from astandrik astandrik is a code owner

@adameat adameat Awaiting requested review from adameat adameat is a code owner

Assignees

@artemmufazalov artemmufazalov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artemmufazalov @Raubzeug