Skip to content

fix: revert workers should be inline to work in other apps #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

fix: revert workers should be inline to work in other apps #3007

merged 1 commit into from
Oct 24, 2025

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Oct 24, 2025 •
edited by github-actions bot
Loading

This reverts commit 85ba867.

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 374 0 2 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔽

Current: 45.87 MB | Main: 45.88 MB
Diff: 4.62 KB (-0.01%)

✅ Bundle size decreased.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Oct 24, 2025

Skipped: This PR does not contain any of your configured keywords: (greptile-review)

@Raubzeug Raubzeug enabled auto-merge October 24, 2025 12:46
@Raubzeug Raubzeug added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 6553da8 Oct 24, 2025
5 checks passed
@Raubzeug Raubzeug deleted the ydb-revert-workers branch October 24, 2025 12:53
@ydb-platform-bot ydb-platform-bot mentioned this pull request Oct 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astandrik astandrik astandrik approved these changes

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov artemmufazalov is a code owner

@adameat adameat Awaiting requested review from adameat adameat is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Raubzeug @astandrik