Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Nov 19, 2025

Part of #2892

https://ydb.tech/docs now works just fine without explicit language (it's added by the size itself)

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 66.13 MB | Main: 66.13 MB
Diff: 0.58 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the documentation link in the InformationPopup component by replacing language-specific URL logic with a single language-agnostic URL. The ydb.tech website now handles language detection automatically, making the client-side language routing unnecessary.

  • Removed the getDocumentationLink() function that dynamically generated language-specific URLs
  • Removed unused imports for settingsManager and SETTING_KEYS
  • Replaced dynamic URL generation with a static https://ydb.tech/docs URL

@artemmufazalov artemmufazalov marked this pull request as ready for review November 19, 2025 20:07
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Skipped: This PR does not contain any of your configured keywords: (greptile-review)

@artemmufazalov artemmufazalov added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 5908d69 Nov 20, 2025
13 checks passed
@artemmufazalov artemmufazalov deleted the update-docs-link branch November 20, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants