feat: export icons #100
Merged
feat: export icons #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Sep 26, 2025
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" fill="currentColor" {...props}> | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| height={16} |
There was a problem hiding this comment.
Added width and height to components, to be able to use them as it is, without additional props
Before: <AsyncReplicationIcon height={16} />
After: <AsyncReplicationIcon />
There was a problem hiding this comment.
Pull Request Overview
This PR exports icon components from the library to enable unified icon usage across schema tree and template components. The change supports consolidating icon implementations by making them publicly available through the main export.
- Exports all icon components through a new
iconsmodule - Standardizes icon sizes by adding explicit height/width props to all SVG components
- Updates NavigationTreeNode to use the exported icons and removes redundant size props
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.ts | Adds export for the icons module |
| src/components/icons/index.ts | Creates barrel export for all icon components |
| src/components/icons/*.tsx | Adds explicit height/width props and reformats SVG attributes |
| src/components/NavigationTree/NavigationTreeNode.tsx | Updates imports to use barrel export and removes size props from icon usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
astandrik
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed to unify icons in schema tree and templates for ydb-platform/ydb-embedded-ui#2906