Skip to content

Conversation

kunga
Copy link
Member

@kunga kunga commented Sep 25, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@kunga kunga self-assigned this Sep 25, 2025
@kunga kunga mentioned this pull request Sep 24, 2025
12 tasks
Copy link

github-actions bot commented Sep 25, 2025

2025-09-25 15:24:44 UTC Pre-commit check linux-x86_64-release-asan for c9da33d has started.
2025-09-25 15:25:02 UTC Artifacts will be uploaded here
2025-09-25 15:29:07 UTC ya make is running...
🔴 2025-09-25 16:27:02 UTC Build failed, see the logs. Also see fail summary
🟡 2025-09-25 16:27:20 UTC ydbd size 3.7 GiB changed* by +175.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f605fee merge: c9da33d diff diff %
ydbd size 3 983 328 456 Bytes 3 983 507 616 Bytes +175.0 KiB +0.004%
ydbd stripped size 1 484 961 184 Bytes 1 485 035 104 Bytes +72.2 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-09-25 15:24:50 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Sep 25, 2025

2025-09-25 15:25:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for c9da33d has started.
2025-09-25 15:25:49 UTC Artifacts will be uploaded here
2025-09-25 15:29:57 UTC ya make is running...
🔴 2025-09-25 16:26:21 UTC Build failed, see the logs. Also see fail summary
🟡 2025-09-25 16:26:34 UTC ydbd size 2.2 GiB changed* by +132.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f605fee merge: c9da33d diff diff %
ydbd size 2 395 157 688 Bytes 2 395 293 424 Bytes +132.6 KiB +0.006%
ydbd stripped size 512 213 416 Bytes 512 244 872 Bytes +30.7 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2025

2025-09-26 13:32:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 86a4093 has started.
2025-09-26 13:33:11 UTC Artifacts will be uploaded here
2025-09-26 13:37:56 UTC ya make is running...
🔴 2025-09-26 14:35:28 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Sep 26, 2025

2025-09-26 13:32:48 UTC Pre-commit check linux-x86_64-release-asan for 86a4093 has started.
2025-09-26 13:33:03 UTC Artifacts will be uploaded here
2025-09-26 13:36:36 UTC ya make is running...
🔴 2025-09-26 14:30:54 UTC Build failed, see the logs. Also see fail summary
🟡 2025-09-26 14:31:12 UTC ydbd size 3.7 GiB changed* by +205.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e663a44 merge: 86a4093 diff diff %
ydbd size 3 984 143 816 Bytes 3 984 354 072 Bytes +205.3 KiB +0.005%
ydbd stripped size 1 485 248 000 Bytes 1 485 338 144 Bytes +88.0 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2025

2025-09-26 15:05:52 UTC Pre-commit check linux-x86_64-release-asan for 315be02 has started.
2025-09-26 15:06:07 UTC Artifacts will be uploaded here
2025-09-26 15:09:39 UTC ya make is running...
🟡 2025-09-26 17:10:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15699 15305 0 112 252 30

🟢 2025-09-26 17:11:00 UTC Build successful.
🟡 2025-09-26 17:11:21 UTC ydbd size 3.7 GiB changed* by +119.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1a42b7a merge: 315be02 diff diff %
ydbd size 3 986 388 736 Bytes 3 986 510 768 Bytes +119.2 KiB +0.003%
ydbd stripped size 1 485 902 464 Bytes 1 485 949 088 Bytes +45.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2025

2025-09-26 15:06:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 315be02 has started.
2025-09-26 15:06:38 UTC Artifacts will be uploaded here
2025-09-26 15:10:17 UTC ya make is running...
🟡 2025-09-26 16:43:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38609 35814 0 2 2762 31

2025-09-26 16:44:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-26 16:55:17 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
511 (only retried tests) 492 0 0 0 19

🟢 2025-09-26 16:55:20 UTC Build successful.
🟢 2025-09-26 16:55:35 UTC ydbd size 2.2 GiB changed* by +83.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a7816a0 merge: 315be02 diff diff %
ydbd size 2 396 817 448 Bytes 2 396 902 928 Bytes +83.5 KiB +0.004%
ydbd stripped size 512 455 464 Bytes 512 480 552 Bytes +24.5 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga marked this pull request as ready for review September 29, 2025 08:48
@kunga kunga requested review from a team as code owners September 29, 2025 08:48
break;
case TIndexBuildInfo::EState::LockBuild:
Y_ENSURE(buildInfo.IsBuildVectorIndex() || buildInfo.IsValidatingUniqueIndex());
Y_ENSURE(buildInfo.IsBuildVectorIndex() && buildInfo.KMeans.Level > 1 || buildInfo.IsValidatingUniqueIndex());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А это почему, тут же вроде про фултекст пр?

Copy link
Member Author

@kunga kunga Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это я выносил GetShardsPath в котором внезапно случай вторичного индекса попадал в проверку buildInfo.KMeans.Level == 1

table = Self->Tables.at(buildInfo.TablePathId);

И искал другие такие сомнительные места, в итоге чуть подвинул где применяется переход в LockBuild, там теперь

https://github.com/kunga/ydb/blob/59de1ca68ec15687c9dbb38927b1f87365c1e7e9/ydb/core/tx/schemeshard/schemeshard_build_index__progress.cpp#L1816

TPath path = GetShardsPath(buildInfo);
if (!path.IsLocked()) { // lock is needed to prevent table shards from being split
    Y_ENSURE(buildInfo.IsBuildVectorIndex() && buildInfo.KMeans.Level > 1);
    ChangeState(buildInfo.Id, TIndexBuildInfo::EState::LockBuild);
    Progress(buildInfo.Id);
    return false;
}

Поэтому тут симметричная проверка добавилась

Copy link

github-actions bot commented Sep 29, 2025

2025-09-29 13:23:41 UTC Pre-commit check linux-x86_64-release-asan for e0ef0b6 has started.
2025-09-29 13:23:45 UTC Artifacts will be uploaded here
2025-09-29 13:27:27 UTC ya make is running...
🟡 2025-09-29 15:46:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15704 15246 0 158 268 32

🟢 2025-09-29 15:46:25 UTC Build successful.
🟡 2025-09-29 15:46:49 UTC ydbd size 3.7 GiB changed* by +136.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e2b4318 merge: e0ef0b6 diff diff %
ydbd size 3 987 279 448 Bytes 3 987 418 696 Bytes +136.0 KiB +0.003%
ydbd stripped size 1 486 188 832 Bytes 1 486 239 104 Bytes +49.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga requested a review from vitalif September 29, 2025 13:24
Copy link

github-actions bot commented Sep 29, 2025

2025-09-29 13:25:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for e0ef0b6 has started.
2025-09-29 13:25:18 UTC Artifacts will be uploaded here
2025-09-29 13:28:54 UTC ya make is running...
🟢 2025-09-29 15:05:35 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38628 35739 0 0 2858 31

🟢 2025-09-29 15:05:45 UTC Build successful.
🟡 2025-09-29 15:06:01 UTC ydbd size 2.2 GiB changed* by +163.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 62b0564 merge: e0ef0b6 diff diff %
ydbd size 2 397 260 768 Bytes 2 397 427 656 Bytes +163.0 KiB +0.007%
ydbd stripped size 512 540 264 Bytes 512 570 664 Bytes +29.7 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga merged commit 6d37ddb into ydb-platform:main Sep 29, 2025
15 checks passed
nfrmtk pushed a commit to nfrmtk/ydb that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants