-
Notifications
You must be signed in to change notification settings - Fork 722
Build fulltext index on SchemeShard #25811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
🟢 |
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
bc9ee24
to
ece7cbc
Compare
⚪ |
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
break; | ||
case TIndexBuildInfo::EState::LockBuild: | ||
Y_ENSURE(buildInfo.IsBuildVectorIndex() || buildInfo.IsValidatingUniqueIndex()); | ||
Y_ENSURE(buildInfo.IsBuildVectorIndex() && buildInfo.KMeans.Level > 1 || buildInfo.IsValidatingUniqueIndex()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А это почему, тут же вроде про фултекст пр?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это я выносил GetShardsPath
в котором внезапно случай вторичного индекса попадал в проверку buildInfo.KMeans.Level == 1
table = Self->Tables.at(buildInfo.TablePathId); |
И искал другие такие сомнительные места, в итоге чуть подвинул где применяется переход в LockBuild, там теперь
TPath path = GetShardsPath(buildInfo);
if (!path.IsLocked()) { // lock is needed to prevent table shards from being split
Y_ENSURE(buildInfo.IsBuildVectorIndex() && buildInfo.KMeans.Level > 1);
ChangeState(buildInfo.Id, TIndexBuildInfo::EState::LockBuild);
Progress(buildInfo.Id);
return false;
}
Поэтому тут симметричная проверка добавилась
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...