Skip to content

Conversation

kunga
Copy link
Member

@kunga kunga commented Sep 30, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

TMeteringStatsHelper.TryFixOldFormat was added for backward compatibilyty, but because we only bill during index build, it is no longer needed anymore

#25811 (comment)

@kunga kunga self-assigned this Sep 30, 2025
Copy link

github-actions bot commented Sep 30, 2025

2025-09-30 13:28:43 UTC Pre-commit check linux-x86_64-release-asan for 908a0a2 has started.
2025-09-30 13:28:57 UTC Artifacts will be uploaded here
2025-09-30 13:32:40 UTC ya make is running...
🟡 2025-09-30 16:02:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15704 15138 0 263 274 29

🟢 2025-09-30 16:02:06 UTC Build successful.
🟢 2025-09-30 16:02:29 UTC ydbd size 3.7 GiB changed* by -1.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 26207ed merge: 908a0a2 diff diff %
ydbd size 3 987 843 744 Bytes 3 987 842 264 Bytes -1.4 KiB -0.000%
ydbd stripped size 1 486 399 712 Bytes 1 486 399 200 Bytes -512 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 30, 2025

🟢 2025-09-30 13:38:19 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Sep 30, 2025

2025-09-30 13:28:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 908a0a2 has started.
2025-09-30 13:29:14 UTC Artifacts will be uploaded here
2025-09-30 13:32:52 UTC ya make is running...
🟡 2025-09-30 15:11:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38630 35751 0 1 2847 31

2025-09-30 15:12:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-30 15:31:37 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
563 (only retried tests) 429 0 0 109 25

🟢 2025-09-30 15:31:40 UTC Build successful.
🟢 2025-09-30 15:31:56 UTC ydbd size 2.2 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f857683 merge: 908a0a2 diff diff %
ydbd size 2 397 644 808 Bytes 2 397 660 880 Bytes +15.7 KiB +0.001%
ydbd stripped size 512 620 648 Bytes 512 625 960 Bytes +5.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga marked this pull request as ready for review September 30, 2025 16:46
@kunga kunga requested a review from a team as a code owner September 30, 2025 16:46
@kunga kunga requested a review from CyberROFL September 30, 2025 16:46
@kunga kunga merged commit a77ee65 into ydb-platform:main Sep 30, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants