-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples should be brought up to date and made prettier #1016
Comments
I could also improve the performance of the style class I provided :) |
I'd prefer if they used an existing theme or library. One of these would be nice:
Nice!
I would prefer to keep the code very simple for the examples. It's more important that they are quick to understand and play with than look nice. I think that we could it for one of the examples, though.
So long as:
we should keep examples that support stdweb That said, I don't think that new examples need to support both. |
This one was just added, do you mind creating an issue for this? |
https://yew-ex-v1.single-page.zainlessbackend.com/ |
Love the UI update!! <3 <3 |
Lovely, thanks! 😊 |
For the todomvc one I'm getting an error Online are: |
https://crm2.examples.yew.rs |
https://fragments2.examples.yew.rs |
https://futures2.examples.yew.rs |
Alright on the todo-list are:
|
Also, I'll look into building some adapter for react-like functional components and redux store :) |
Awesome! Can you create a new issue for that and describe the API? |
Huh multithreading is not working at all. It can't find the files needed to work the worker, seems the project has to be set up in a very specific way for that. Wonder how we can fix that |
The web-sys multithread example? There is a readme for that, it's an unusual setup |
@ZainlessBrombie where did you leave off with example updates? I think we could leverage some community component libraries to help with this effort |
I honestly did not continue after updating this and focused on the hooks API. I have not forgotten about it though, I'm just pretty booked right now :) |
@ZainlessBrombie no worries! take your time :) |
I run in the issue also. What causes the issue and how it could be solved? |
My suspicion is that is an error caused by rules around how ES5 (a Javascript specification – not sure if it's ES5 of ES6) defined Javascript modules. I'd suggest making sure the relevant |
The exception disappears if this line yew/examples/todomvc/static/index.html Line 10 in 1e609b4
is modified as suggested. But in this case my browsers (Firefox 75.0, Chromium 81.0.4044.113) show an empty page. |
- makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016
- makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016
- makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016
- makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016
* amendment of todomvc example - makes it ready for wasm-pack build mentioned in issues #1079 and #1016 * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
* amendment of todomvc example - makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016 * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
* amendment of todomvc example - makes it ready for wasm-pack build mentioned in issues #1079 and #1016 * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
* amendment of todomvc example - makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016 * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com> Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
I think this has been achieved to a reasonable degree (there will always be things to improve) so I'm going to close this now. |
This should be moved to Done in the relevant projects |
Is your feature request related to a problem? Please describe.
The features currently don't look very pleasing and e.g. the webgl one didn't compile. It might be a good idea to bring them up to date / do a new set of examples.
Describe the solution you'd like
Someone (could be me) should redo the examples with proper css styling and bring them up to date
Describe alternatives you've considered
We could keep them looking the way they do right now for simplicities sake, but I think some styling won't hurt. We need to represent ourselves after all :)
Additional context
A) I'd redo the examples but while I'm full stack design is not one of my primary skills. Might need some pointers from someone regarding the design after the initial draft.
B) Here is a simple little styled component class I wrote. Mind if I use it for styling in the examples?
https://pastebin.com/j2qtsmTm
C) Do we still need to support std_web for the examples? It would be simpler to just go with web_sys imho, after all std_web has seen no activity in the past months and web_sys is more official
The text was updated successfully, but these errors were encountered: