refactor: Remove redundant offset in shiftLeftRightAttribute call in NestedSetsBehavior class.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

Summary by CodeRabbit

• Bug Fixes
  • Improved the handling of nested set node deletions, ensuring more accurate updates to the structure after a node is removed.

[coderabbitai]

Walkthrough

The change updates the argument in the shiftLeftRightAttribute call within the afterDelete() method of NestedSetsBehavior.php, removing the increment from $rightValue + 1 to simply $rightValue. No public interfaces or exported declarations are altered.

Changes

File(s)	Change Summary
src/NestedSetsBehavior.php	Modified argument in shiftLeftRightAttribute call in afterDelete() method.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NestedSetsBehavior
    participant Database

    User->>NestedSetsBehavior: Delete node
    NestedSetsBehavior->>Database: Remove node
    NestedSetsBehavior->>NestedSetsBehavior: afterDelete()
    NestedSetsBehavior->>NestedSetsBehavior: shiftLeftRightAttribute($rightValue, -2)
    NestedSetsBehavior->>Database: Update left/right attributes

Loading

Possibly related PRs

• refactor: remove redundant +1 offset in NestedSetsBehavior class in shiftLeftRightAttribute calls. #13: Refactors calls to shiftLeftRightAttribute, including the same change to the argument in afterDelete().

Suggested labels

bug

Poem

A hop and a skip, a node takes flight,
Adjusting numbers, just so right.
No more plus one, the shift is neat,
Nested sets now feel complete.
With careful code, the trees align—
A rabbit’s touch, oh so fine! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 phpcs (3.7.2)

src/NestedSetsBehavior.php

Warning: PHP Startup: Invalid date.timezone value 'UTC', using 'UTC' instead in Unknown on line 0

Fatal error: Uncaught Error: Class "Phar" not found in /usr/local/bin/phpcs:3
Stack trace:
#0 {main}
thrown in /usr/local/bin/phpcs on line 3

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4af8a45 and 9ddd372.

📒 Files selected for processing (1)

• src/NestedSetsBehavior.php (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: terabytesoftw
PR: yii2-extensions/nested-sets-behavior#13
File: src/NestedSetsBehavior.php:145-145
Timestamp: 2025-06-29T11:22:41.839Z
Learning: The user terabytesoftw prefers to keep PRs focused and small, implementing enhancements in separate dedicated PRs rather than bundling multiple changes together.

⏰ Context from checks skipped due to timeout of 90000ms (12)

• GitHub Check: phpunit-compatibility / PHP 8.4-ubuntu-latest
• GitHub Check: phpunit-compatibility / PHP 8.1-windows-latest
• GitHub Check: phpunit-compatibility / PHP 8.3-ubuntu-latest
• GitHub Check: phpunit-compatibility / PHP 8.2-windows-latest
• GitHub Check: phpunit-compatibility / PHP 8.4-windows-latest
• GitHub Check: phpunit-compatibility / PHP 8.2-ubuntu-latest
• GitHub Check: phpunit-compatibility / PHP 8.1-ubuntu-latest
• GitHub Check: phpunit-compatibility / PHP 8.3-windows-latest
• GitHub Check: phpunit / PHP 8.1-windows-latest
• GitHub Check: phpunit / PHP 8.2-windows-latest
• GitHub Check: phpunit / PHP 8.4-windows-latest
• GitHub Check: phpunit / PHP 8.3-windows-latest

🔇 Additional comments (1)

src/NestedSetsBehavior.php (1)

177-177: LGTM! This fix correctly removes the redundant offset.

The change properly addresses a bug in the nested set deletion logic. When deleting a node while preserving its children, the shift operation should start from $rightValue (the right boundary of the deleted node) to ensure all positions after the deleted node are correctly shifted by -2 to close the gap. The previous $rightValue + 1 would incorrectly skip shifting the position immediately following the deleted node's boundary.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4af8a45) to head (9ddd372).

Additional details and impacted files

@@             Coverage Diff             @@
##                main       #17   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        85        85           
===========================================
  Files              2         2           
  Lines            458       458           
===========================================
  Hits             458       458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR fixes a boundary issue in the nested set deletion logic by removing an unnecessary +1 offset when shifting node positions.

• Adjust shift range start from $rightValue + 1 to $rightValue for correct reindexing after deletion

Comments suppressed due to low confidence (1)

src/NestedSetsBehavior.php:177

• Consider adding or updating unit tests to cover the boundary case where a node is deleted, verifying that shifting starts at the correct right value without the +1 offset.

            $this->shiftLeftRightAttribute($rightValue, -2);