feat: Add tests to include validation scenarios for insertAfter method.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

Summary by CodeRabbit

• Tests
  • Added a new test to verify the behavior of inserting nodes with and without strict validation enabled.

[coderabbitai]

Walkthrough

A new test method was added to the NestedSetsBehaviorTest class to verify the behavior of the insertAfter method when using the runValidation parameter with strict validation. The test checks outcomes for both enabled and disabled validation scenarios, ensuring correct handling of invalid nodes.

Changes

File(s)	Change Summary
tests/NestedSetsBehaviorTest.php	Added a test method for insertAfter with runValidation parameter using strict validation logic.

Possibly related PRs

• refactor: Validate non-null value for right attribute in beforeInsertNode() method of NestedSetsBehavior class. #23: Refactors internal validation logic and adds tests for attribute validation during node insertion, related to node insertion validation.
• feat: Add TreeWithStrictValidation model with strict validation rules. Update tests to include validation scenarios for appendTo method. #25: Adds validation tests for the appendTo method on the same model, complementing the new insertAfter validation test.

Poem

A bunny hopped through nested trees,
Testing strict rules with agile ease.
Insert after, validate true or false,
Ensuring every node’s pulse.
With every test, the forest grows,
As rabbit wisdom gently flows! 🐇🌳

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 phpcs (3.7.2)

tests/NestedSetsBehaviorTest.php

Warning: PHP Startup: Invalid date.timezone value 'UTC', using 'UTC' instead in Unknown on line 0

Fatal error: Uncaught Error: Class "Phar" not found in /usr/local/bin/phpcs:3
Stack trace:
#0 {main}
thrown in /usr/local/bin/phpcs on line 3

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e0efc1 and 81fbc60.

📒 Files selected for processing (1)

• tests/NestedSetsBehaviorTest.php (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: terabytesoftw
PR: yii2-extensions/nested-sets-behavior#13
File: src/NestedSetsBehavior.php:145-145
Timestamp: 2025-06-29T11:22:41.839Z
Learning: The user terabytesoftw prefers to keep PRs focused and small, implementing enhancements in separate dedicated PRs rather than bundling multiple changes together.

🧬 Code Graph Analysis (1)

tests/NestedSetsBehaviorTest.php (4)

tests/TestCase.php (1)

• generateFixtureTree (168-202)

tests/support/model/Tree.php (1)

• Tree (17-64)

src/NestedSetsBehavior.php (2)

• isRoot (753-756)
• insertAfter (613-619)

tests/support/model/TreeWithStrictValidation.php (1)

• TreeWithStrictValidation (14-24)

🪛 PHPMD (2.15.0)

tests/NestedSetsBehaviorTest.php

1838-1838: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testInsertAfterWithRunValidationParameterUsingStrictValidation'. (Clean Code Rules)

(StaticAccess)

---

1878-1878: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\TreeWithStrictValidation' in method 'testInsertAfterWithRunValidationParameterUsingStrictValidation'. (Clean Code Rules)

(StaticAccess)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: phpunit-compatibility / PHP 8.2-windows-latest
• GitHub Check: phpunit-compatibility / PHP 8.4-windows-latest

🔇 Additional comments (1)

tests/NestedSetsBehaviorTest.php (1)

1834-1884: Excellent test implementation following established patterns.

This test method properly validates the insertAfter method's behavior with the runValidation parameter, mirroring the existing appendTo test pattern. The implementation correctly:

• Tests both validation enabled (default) and disabled scenarios
• Uses appropriate invalid data that triggers TreeWithStrictValidation rules
• Verifies database persistence when validation is disabled
• Follows consistent assertion patterns with clear, descriptive messages

The test structure aligns well with your preference for focused, well-tested functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3e0efc1) to head (81fbc60).

Additional details and impacted files

@@             Coverage Diff             @@
##                main       #26   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        90        90           
===========================================
  Files              2         2           
  Lines            469       469           
===========================================
  Hits             469       469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR adds a new test to verify insertAfter() behavior under strict validation when runValidation is both enabled and disabled.

• Introduces testInsertAfterWithRunValidationParameterUsingStrictValidation covering:
  • Failure case when validation runs by default.
  • Success case when validation is skipped.
• Ensures the node is persisted when runValidation=false.

Comments suppressed due to low confidence (2)

tests/NestedSetsBehaviorTest.php:1849

• [nitpick] Consider renaming variables like $invalidNode and $invalidNode2 to more descriptive names (e.g., $nodeWithValidationErrors and $nodeSkippingValidation) to clarify their roles in the test.

        $invalidNode = new TreeWithStrictValidation(['name' => 'x']);

tests/NestedSetsBehaviorTest.php:1878

• Consider adding assertions to verify that the persisted node is correctly positioned relative to the target (for example, checking the left and right boundaries) to fully validate the insertAfter behavior.

        $persistedNode = TreeWithStrictValidation::findOne($invalidNode2->id);