Skip to content

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 8, 2020

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
Fixed issues #21

@vjik vjik added the status:under development Someone is working on a pull request. label Nov 8, 2020
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Nov 8, 2020
@vjik vjik requested a review from a team November 8, 2020 20:03
@samdark
Copy link
Member

samdark commented Nov 9, 2020

Here's a simpler fix: #25

return unlink($path);
}
return DIRECTORY_SEPARATOR === '\\' // is windows
? static::windowsUnlink($path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was bad in a single method.

@samdark
Copy link
Member

samdark commented Nov 10, 2020

Let's do the following:

  1. Merge windowsUnlink() with unlink(). There's no need to have 2 methods and original one is clear enough.
  2. Add phpdoc for isEmptyDirectory().

@vjik
Copy link
Member Author

vjik commented Nov 10, 2020

Let's do the following:

  1. Merge windowsUnlink() with unlink(). There's no need to have 2 methods and original one is clear enough.
  2. Add phpdoc for isEmptyDirectory().

Done

@samdark samdark merged commit 1d8c1db into yiisoft:master Nov 10, 2020
@vjik vjik deleted the del branch November 24, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants